You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/08/23 16:36:18 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1346: DISPATCH-2235: Dump time delay before lock is acquired
kgiusti opened a new pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346
- top five total waits:
$ sort --reverse --numeric --key 3 <output-file> | head -5
- top five with waits > 1000 nsc:
$ sort --reverse --numeric --key 7 <output-file> | head -5
- top five maximum single-call wait times:
sort --reverse --numeric --key 9 <output-file> | head -5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1346: DISPATCH-2235: Dump time delay before lock is acquired
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346#issuecomment-904168058
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1346](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b5cdde) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/e9679c519a1028508085ef0033109879ca085b59?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9679c5) will **decrease** coverage by `0.16%`.
> The diff coverage is `98.64%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
- Coverage 84.73% 84.56% -0.17%
==========================================
Files 114 114
Lines 28394 28414 +20
==========================================
- Hits 24059 24029 -30
- Misses 4335 4385 +50
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/posix/threading.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Bvc2l4L3RocmVhZGluZy5j) | `96.05% <96.66%> (+0.66%)` | :arrow_up: |
| [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `83.79% <100.00%> (ø)` | |
| [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.36% <100.00%> (ø)` | |
| [src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FsbG9jX3Bvb2wuYw==) | `88.59% <100.00%> (-5.14%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRhaW5lci5j) | `84.41% <100.00%> (ø)` | |
| [src/entity\_cache.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2VudGl0eV9jYWNoZS5j) | `100.00% <100.00%> (ø)` | |
| [src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2xvZy5j) | `91.20% <100.00%> (ø)` | |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <100.00%> (+0.06%)` | :arrow_up: |
| [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BvbGljeS5j) | `87.31% <100.00%> (ø)` | |
| [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.43% <100.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e9679c5...9b5cdde](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1346: DISPATCH-2235: Dump time delay before lock is acquired
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346#discussion_r694147335
##########
File path: src/router_core/forwarder.c
##########
@@ -154,7 +154,9 @@ qdr_delivery_t *qdr_forward_new_delivery_CT(qdr_core_t *core, qdr_delivery_t *in
out_dlv->delivery_id = next_delivery_id();
out_dlv->link_id = out_link->identity;
out_dlv->conn_id = out_link->conn_id;
- out_dlv->dispo_lock = sys_mutex();
+ char name[64];
+ snprintf(name, sizeof(name), "delivery-%"PRIu32, out_dlv->delivery_id);
Review comment:
This snprintf is in the fast path. Is this a problem ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1346: DISPATCH-2235: Dump time delay before lock is acquired
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346#discussion_r694994166
##########
File path: src/router_core/forwarder.c
##########
@@ -154,7 +154,9 @@ qdr_delivery_t *qdr_forward_new_delivery_CT(qdr_core_t *core, qdr_delivery_t *in
out_dlv->delivery_id = next_delivery_id();
out_dlv->link_id = out_link->identity;
out_dlv->conn_id = out_link->conn_id;
- out_dlv->dispo_lock = sys_mutex();
+ char name[64];
+ snprintf(name, sizeof(name), "delivery-%"PRIu32, out_dlv->delivery_id);
Review comment:
It's probably overkill, especially for this lock which is hardly used.
In fact we probably want to avoid storing the mutex name (strdup call) when we're not explicitly debugging the locks.
Update coming soon...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1346: DISPATCH-2235: Dump time delay before lock is acquired
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346#issuecomment-904168058
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1346](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7385e53) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/e9679c519a1028508085ef0033109879ca085b59?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9679c5) will **decrease** coverage by `0.07%`.
> The diff coverage is `98.48%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
- Coverage 84.73% 84.66% -0.08%
==========================================
Files 114 114
Lines 28394 28405 +11
==========================================
- Hits 24059 24048 -11
- Misses 4335 4357 +22
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/posix/threading.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Bvc2l4L3RocmVhZGluZy5j) | `95.83% <96.15%> (+0.44%)` | :arrow_up: |
| [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `83.79% <100.00%> (ø)` | |
| [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.36% <100.00%> (ø)` | |
| [src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FsbG9jX3Bvb2wuYw==) | `93.81% <100.00%> (+0.08%)` | :arrow_up: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRhaW5lci5j) | `84.41% <100.00%> (ø)` | |
| [src/entity\_cache.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2VudGl0eV9jYWNoZS5j) | `100.00% <100.00%> (ø)` | |
| [src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2xvZy5j) | `91.20% <100.00%> (ø)` | |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.55% <100.00%> (+0.13%)` | :arrow_up: |
| [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BvbGljeS5j) | `87.31% <100.00%> (ø)` | |
| [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.43% <100.00%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1346/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e9679c5...7385e53](https://codecov.io/gh/apache/qpid-dispatch/pull/1346?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org