[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true

[GitBox <gi...@apache.org>]

Pearl1594 commented on a change in pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#discussion_r486122077



##########
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##########
@@ -199,6 +200,9 @@ public boolean checkAccess(Account caller, ControlledEntity entity, AccessType a
     private boolean checkOperationPermitted(Account caller, ControlledEntity entity) {
         User user = CallContext.current().getCallingUser();
         Project project = projectDao.findByProjectAccountId(entity.getAccountId());
+        if (project == null) {

Review comment:
       this method is called only if the entity is owned by a project - which would mean that ideally project should be present if the entity's account is of Project type




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org