You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/28 20:53:01 UTC
[jira] [Commented] (METRON-587) Integration tests should use common
processor implementations where possible
[ https://issues.apache.org/jira/browse/METRON-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703083#comment-15703083 ]
ASF GitHub Bot commented on METRON-587:
---------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/incubator-metron/pull/374
METRON-587 Integration tests should use common processor implementations where possible
We have 7 or so integration tests that implement the Processor interface. Much of the code in these implementations is the same. It would be better for the system if we had some common implementations of the Processor interface.
This would make it easier to write correct tests
This would reduce errors from copy/paste test generation
This would clean up the codebase and make it easier to understand
This PR creates a KafkaProcessor class which implements the common processor code used for all the Parser Integration Test based classes, The WriterBolt Integration Test and the Enrichment Integration tests.
The pcap and simple hbase enrichments are 'different' enough to continue to use their own interface implementations. The indexing tests are less likely to have new additions to them, and can be part of a subsequent effort if required.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/incubator-metron METRON-587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/374.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #374
----
commit 0ae8378e21ad84a279cc41d829cb873fd1287e99
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-23T19:09:53Z
METRON-587 create Processor implementation for Kafka based tests
Implment in EnrichmentIntegrationTest as poc
commit 93a676d278b763ca6f92f6f8d8863ecd1ceabd96
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-28T11:39:11Z
merge tracking branch apache/master
commit 1b725add240333f483de0f1922be597a3423f7b6
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-28T15:01:43Z
For new enrichment tests, get errors at the same time as getting messages
commit 20ef76199fa5b67e289c96b584086f31a5799558
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-28T19:45:19Z
more api evolution
handle more cases
ASA integration failing with timeouts?
commit 21a76c0f4023b1182e0463397689a5e54cc889e2
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-28T20:36:42Z
add in all the topics
allow more retries
commit 5e09cf57ab557037883e598fca4e48a28b968342
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-28T20:37:56Z
Merge remote-tracking branch 'apache/master' into METRON-587
commit 10e159d1054fa37b90d9353d8e14def8217dae00
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-28T20:49:39Z
fix up imports
----
> Integration tests should use common processor implementations where possible
> ----------------------------------------------------------------------------
>
> Key: METRON-587
> URL: https://issues.apache.org/jira/browse/METRON-587
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> We have 7 or so integration tests that implement the Processor interface. Much of the code in these implementations is the same. It would be better for the system if we had some common implementations of the Processor interface.
> - This would make it easier to write correct tests
> - This would reduce errors from copy/paste test generation
> - This would clean up the codebase and make it easier to understand
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)