You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/08 01:39:00 UTC

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4331

Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9
......................................................................

Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

This commit had a small semantic conflict with another commit that went
into master before it. This fixes the trivial issue.

Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/4331/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9
......................................................................


Patch Set 1: Verified+1

Build got past compilation, so checking this in to fix master

-- 
To view, visit http://gerrit.cloudera.org:8080/4331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3272/

-- 
To view, visit http://gerrit.cloudera.org:8080/4331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9
......................................................................


Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

This commit had a small semantic conflict with another commit that went
into master before it. This fixes the trivial issue.

Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
Reviewed-on: http://gerrit.cloudera.org:8080/4331
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f714d6f1eb2929784f0a2cf2e18a18c97ac980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No