[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #1108: ble_ll: Add nrf52_bsim support

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #1108:
URL: https://github.com/apache/mynewt-nimble/pull/1108#discussion_r805686568



##########
File path: babblesim/hw/babblesim/scripts/pre_build1.sh
##########
@@ -0,0 +1,50 @@
+#!/bin/bash

Review comment:
       license is missing

##########
File path: babblesim/hw/mcu/nordic/nrf52_bsim/include/mcu/cmsis_nvic.h
##########
@@ -0,0 +1,28 @@
+/* mbed Microcontroller Library - cmsis_nvic

Review comment:
       this is BSD license (as CMSIS-core),  can be left as is

##########
File path: babblesim/hw/bsp/nrf52_bsim/src/arch/bsim_arch/startup_nrf52_bsim.c
##########
@@ -0,0 +1,212 @@
+#include "nrf.h"

Review comment:
       license

##########
File path: babblesim/nrfx/scripts/link_nrfx.sh
##########
@@ -0,0 +1,6 @@
+#!/bin/bash

Review comment:
       license

##########
File path: babblesim/libc/src/strlcat.c
##########
@@ -0,0 +1,30 @@
+/*

Review comment:
       this is copied from baselibc so should have same license  (put LICENSE from core/baselibc into babblesim/libc folder)

##########
File path: babblesim/hw/mcu/nordic/nrf52_bsim/src/system_nrf52.c
##########
@@ -0,0 +1,37 @@
+/* Copyright (c) 2012 ARM LIMITED

Review comment:
       can be left as is

##########
File path: babblesim/libc/src/strlcpy.c
##########
@@ -0,0 +1,26 @@
+/*

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org