[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4200: Adding script to build and publish docker image

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4200: Adding script to build and publish docker image
URL: https://github.com/apache/incubator-pinot/pull/4200#discussion_r283033921
 
 

 ##########
 File path: docker/Dockerfile
 ##########
 @@ -0,0 +1,35 @@
+FROM openjdk:8u181-jdk-stretch
+
+LABEL MAINTAINER=fx19880617@gmail.com
+
+ARG PINOT_BRANCH=master
+ARG PINOT_GIT_URL="https://github.com/apache/incubator-pinot.git"
+RUN echo "Trying to build Pinot from [ ${PINOT_GIT_URL} ] on branch [ ${PINOT_BRANCH} ]"
+ENV PINOT_HOME=/opt/pinot
 
 Review comment:
   Just try to understand, can we pass these through environment variables?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org