Re: [PR] at32uc3a0: Initial work for SimpleMachines' Mizar32-A [nuttx]

["acassis (via GitHub)" <gi...@apache.org>]

acassis commented on code in PR #11709:
URL: https://github.com/apache/nuttx/pull/11709#discussion_r1493771993


##########
arch/avr/src/at32uc3/at32uc3_lowconsole.c:
##########
@@ -348,11 +348,18 @@ void up_consoleinit(void)
 
 #endif
 
-  /* Enable selected clocks (and disabled unselected clocks) */
+  /* Enable selected clocks (and disable unselected clocks) */
 
   regval = getreg32(AVR32_PM_PBAMASK);
+#ifdef CONFIG_ARCH_CHIP_AT32UC3B
   regval &= ~(PM_PBAMASK_USART0 | PM_PBAMASK_USART1 | PM_PBAMASK_USART2);
   regval |= pbamask;
+#else
+  /*
+   * In the case of Mizar32, enable all USART clocks.
+   */

Review Comment:
   Since it is less than 80 columns, please keep it in a single line



##########
arch/avr/src/at32uc3/at32uc3_gpio.c:
##########
@@ -63,19 +63,19 @@
 static uint32_t g_portmap[AVR32_NGPIO_PORTS] =
 {
 #if AVR32_NGPIO > 0
-  AVR32_GPIO0_BASE
+  AVR32_GPIO0_BASE,

Review Comment:
   I think it is only aesthetic, but the way he suggests seems better to visualize



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org