You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/24 02:52:13 UTC
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman opened a new pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
enapps-enorman opened a new pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58
These changes appear to fix the problem locally, but I would appreciate a review to verify it doesn't cause any adverse side effects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] removed a comment on pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#issuecomment-700179322
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=SECURITY_HOTSPO
T) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='64.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_coverage&view=list) [64.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#discussion_r494083414
##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java
##########
@@ -65,6 +68,15 @@
@Override
public void execute() throws MojoExecutionException {
checkPreconditions();
+
Review comment:
I think this doesn't work - it's totally legitimate to use the aggregate mojo more than once in a project, especially when you use profiles with different aggregations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman commented on a change in pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#discussion_r494540600
##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java
##########
@@ -65,6 +68,15 @@
@Override
public void execute() throws MojoExecutionException {
checkPreconditions();
+
Review comment:
Thanks for reviewing and I see your point. I left a comment on the JIRA ticket for your consideration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#issuecomment-700179322
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=SECURITY_HOTSPO
T) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='64.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_coverage&view=list) [64.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#discussion_r494083414
##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java
##########
@@ -65,6 +68,15 @@
@Override
public void execute() throws MojoExecutionException {
checkPreconditions();
+
Review comment:
I think this doesn't work - it's totally legitimate to use the aggregate mojo more than once in a project, especially when you use profiles with different aggregations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman commented on a change in pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#discussion_r494540600
##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java
##########
@@ -65,6 +68,15 @@
@Override
public void execute() throws MojoExecutionException {
checkPreconditions();
+
Review comment:
Thanks for reviewing and I see your point. I left a comment on the JIRA ticket for your consideration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] bosschaert commented on pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
bosschaert commented on pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#issuecomment-700508030
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#issuecomment-700192462
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=SECURITY_HOTSPO
T) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='78.2%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_coverage&view=list) [78.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=58&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman merged pull request #58: SLING-9656 gracefully handle scenarios where the AggregateFeaturesMojo gets invoked more than once during the build
Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #58:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org