You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "xiong duan (Jira)" <ji...@apache.org> on 2023/07/03 08:19:00 UTC
[jira] [Commented] (CALCITE-5798) Improve simplification of '(x < y) IS NOT TRUE' and '(x < y) IS TRUE' when x and y are not nullable
[ https://issues.apache.org/jira/browse/CALCITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739492#comment-17739492 ]
xiong duan commented on CALCITE-5798:
-------------------------------------
[~Runking] Hi, I prefer
|'(1 < x) IS NOT TRUE' when x is not nullable should be simplified to '1 >= x'|
And this summary is complete. The '(x < y) IS TRUE' is just another test case, covered by test is enough.
> Improve simplification of '(x < y) IS NOT TRUE' and '(x < y) IS TRUE' when x and y are not nullable
> ---------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5798
> URL: https://issues.apache.org/jira/browse/CALCITE-5798
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Major
> Labels: pull-request-available
>
> Currently '(1 < x) IS NOT TRUE' when pulled up predicates contain 'x IS NOT NULL' is not simplified, and keeps it as it is.
>
> It can and should be simplified to '1 >= x', which is more concise and useful for further simplification, such as CALCITE-5780
>
> Note that this Jira is splited from CALCITE-5780, which makes this part of codes more clear, and follows the principle that a Jira only discusses one issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)