You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/08 06:03:54 UTC
[GitHub] [spark] HyukjinKwon commented on pull request #33931: [SPARK-36689][PYTHON] Cleanup the deprecated APIs and raise proper warning message.
HyukjinKwon commented on pull request #33931:
URL: https://github.com/apache/spark/pull/33931#issuecomment-914943584
Can you fix tests?
```
======================================================================
ERROR [0.038s]: test_missing (pyspark.pandas.tests.test_series.SeriesTest)
----------------------------------------------------------------------
pyspark.pandas.exceptions.PandasNotImplementedError: The method `pd.Series.slice_shift()` is deprecated in pandas and will therefore not be supported in pandas-on-Spark. Use `shift` instead.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/__w/spark/spark/python/pyspark/pandas/tests/test_series.py", line 1040, in test_missing
getattr(psser, name)()
AssertionError: "method.*Series.*tshift.*is deprecated" does not match "The method `pd.Series.slice_shift()` is deprecated in pandas and will therefore not be supported in pandas-on-Spark. Use `shift` instead."
----------------------------------------------------------------------
```
Otherwise looks good. cc @ueshin too fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org