You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2016/04/03 17:00:50 UTC
Advice on package for Encoder and ByteBufferDestination
What package should the Encoder and ByteBufferDestination interfaces live
in?
Currently they are both in org.apache.logging.log4j.core.layout, but
o.a.l.l.core.Layout extends Encoder and it seems a bit strange to have
Layout's super interface live in a subpackage.
I think there are pros and cons to leaving them in the layout package or
pulling them up to the core package, but I'd be interested to hear
everyone's feedback.
Remko
Re: Advice on package for Encoder and ByteBufferDestination
Posted by Matt Sicker <bo...@gmail.com>.
I would imagine most people extend from AbstractLayout or
AbstractStringLayout if they even make custom layouts.
On 4 April 2016 at 12:31, Gary Gregory <ga...@gmail.com> wrote:
> And I imagine that _moving_ Layout is too much of a BC break even though
> it is in Core?
>
> Gary
>
> On Sun, Apr 3, 2016 at 10:40 AM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> IMO, the oddness is that Layout is NOT in the layout package. So I would
>> leave all layout items in layout...
>>
>> Gary
>>
>> On Sun, Apr 3, 2016 at 8:00 AM, Remko Popma <re...@gmail.com>
>> wrote:
>>
>>> What package should the Encoder and ByteBufferDestination interfaces
>>> live in?
>>>
>>> Currently they are both in org.apache.logging.log4j.core.layout, but
>>> o.a.l.l.core.Layout extends Encoder and it seems a bit strange to have
>>> Layout's super interface live in a subpackage.
>>>
>>> I think there are pros and cons to leaving them in the layout package or
>>> pulling them up to the core package, but I'd be interested to hear
>>> everyone's feedback.
>>>
>>> Remko
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <bo...@gmail.com>
Re: Advice on package for Encoder and ByteBufferDestination
Posted by Gary Gregory <ga...@gmail.com>.
And I imagine that _moving_ Layout is too much of a BC break even though it
is in Core?
Gary
On Sun, Apr 3, 2016 at 10:40 AM, Gary Gregory <ga...@gmail.com>
wrote:
> IMO, the oddness is that Layout is NOT in the layout package. So I would
> leave all layout items in layout...
>
> Gary
>
> On Sun, Apr 3, 2016 at 8:00 AM, Remko Popma <re...@gmail.com> wrote:
>
>> What package should the Encoder and ByteBufferDestination interfaces live
>> in?
>>
>> Currently they are both in org.apache.logging.log4j.core.layout, but
>> o.a.l.l.core.Layout extends Encoder and it seems a bit strange to have
>> Layout's super interface live in a subpackage.
>>
>> I think there are pros and cons to leaving them in the layout package or
>> pulling them up to the core package, but I'd be interested to hear
>> everyone's feedback.
>>
>> Remko
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Advice on package for Encoder and ByteBufferDestination
Posted by Gary Gregory <ga...@gmail.com>.
IMO, the oddness is that Layout is NOT in the layout package. So I would
leave all layout items in layout...
Gary
On Sun, Apr 3, 2016 at 8:00 AM, Remko Popma <re...@gmail.com> wrote:
> What package should the Encoder and ByteBufferDestination interfaces live
> in?
>
> Currently they are both in org.apache.logging.log4j.core.layout, but
> o.a.l.l.core.Layout extends Encoder and it seems a bit strange to have
> Layout's super interface live in a subpackage.
>
> I think there are pros and cons to leaving them in the layout package or
> pulling them up to the core package, but I'd be interested to hear
> everyone's feedback.
>
> Remko
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory