You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "uschindler (via GitHub)" <gi...@apache.org> on 2023/11/14 21:42:14 UTC
[PR] Fix errorprone with alternative runtime [lucene]
uschindler opened a new pull request, #12808:
URL: https://github.com/apache/lucene/pull/12808
See analysis on dev@lucene.apache.org: https://lists.apache.org/thread/svt6bqqwdkb4kq7b9zhx630n4sj27ovq
This fixes the recent Jenkins failures with branch_9x. On main branch the extra check is useless anyways, as JDK versions are always >=17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix errorprone with alternative runtime [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler merged PR #12808:
URL: https://github.com/apache/lucene/pull/12808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix errorprone with alternative runtime [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12808:
URL: https://github.com/apache/lucene/pull/12808#issuecomment-1811439713
Merged to lucene/branch_9x, solr/main + solr/branch_9x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix errorprone with alternative runtime [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12808:
URL: https://github.com/apache/lucene/pull/12808#issuecomment-1811585147
Hi @dweiss,
The issue with errorprone is exactly the same like we have seen for turbocharger of Java options: https://github.com/gradle/gradle/issues/22746
The new version of errorprone plugin fixed the issues with flags and when forking is enabled it adds the JVM options, but without `-J`. With toolchains or when forking without custom java home this works correct, but when you have a custom java home passed to fork options it breaks.
So it's not Errorprone's fault, but the same Gradle bug over and over.
I will think of a possibility to wrap all ArgumentProviders (also the ones added by errorprone) before executing task's main action and add `-J`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix errorprone with alternative runtime [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12808:
URL: https://github.com/apache/lucene/pull/12808#issuecomment-1811586309
See also https://github.com/apache/beam/pull/24930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org