You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/28 03:17:24 UTC

[jira] [Commented] (AVRO-1658) Add avroDoc on reflect

    [ https://issues.apache.org/jira/browse/AVRO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843796#comment-15843796 ] 

ASF GitHub Bot commented on AVRO-1658:
--------------------------------------

GitHub user aeroevan opened a pull request:

    https://github.com/apache/avro/pull/189

    AVRO-1658: Java: Add reflection annotation @AvroDoc.

    @AvroMeta can be used for other keys, but doc is passed into the field's
    constructor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aeroevan/avro AVRO-1658

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #189
    
----
commit c0f1aa0ec738efcde4f48d48929f1c3d24451acf
Author: Evan McClain <ae...@gmail.com>
Date:   2016-07-30T23:47:50Z

    AVRO-1658: Java: Add reflection annotation @AvroDoc.
    
    @AvroMeta can be used for other keys, but doc is passed into the field's
    constructor.

----


> Add avroDoc on reflect
> ----------------------
>
>                 Key: AVRO-1658
>                 URL: https://issues.apache.org/jira/browse/AVRO-1658
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Zhaonan Sun
>              Labels: reflection
>         Attachments: 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch, 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch, 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch
>
>
> Looks like @AvroMeta can't add reserved fields, like @AvroMeta("doc", "some doc") will have exceptions.
> I would be greate if we have a @AvroDoc("some documentations") in org.apache.avro.reflect



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)