[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1141: MINIFICPP-1479-Rework integration tests for HashContent

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1141:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1141#discussion_r676643129



##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -266,3 +266,10 @@ def check_azure_storage_server_data(self, cluster_name, object_data):
     def wait_for_kafka_consumer_to_be_registered(self, cluster_name):
         cluster = self.acquire_cluster(cluster_name)
         assert cluster.wait_for_kafka_consumer_to_be_registered()
+
+    def check_minifi_log_contents(self, line):
+        line_found = False
+        for cluster in self.clusters.values():
+            if cluster.get_engine() == "minifi-cpp":
+                line_found = cluster.wait_for_app_logs(line, 60)
+        assert line_found

Review comment:
       Currently it would be better to have the cluster_name, although there may be still multiple minifi containers in a single cluster. After #1121 is merged it will be much simpler as there will only be a single cluster and you can specify the container you want to get the logs from.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org