You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/09/08 18:31:26 UTC
Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed to
use correct workflow, javadocs added
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-693
https://issues.apache.org/jira/browse/FALCON-693
Repository: falcon-git
Description
-------
Tests with zero inp/outp fixed to use correct workflow, javadocs added
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 638768d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 1225525
Diff: https://reviews.apache.org/r/25446/diff/
Testing
-------
Tested.
Thanks,
Paul Isaychuk
Re: Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed
to use correct workflow, javadocs added
Posted by Paul Isaychuk <pi...@hortonworks.com>.
> On Sept. 8, 2014, 11:31 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java, line 68
> > <https://reviews.apache.org/r/25446/diff/1/?file=682653#file682653line68>
> >
> > Why have we changed the workflow that was being used ? And in case we want to do that then we can get rid of aggregateWorkflowDir field.
Sure, removed this variable in updated patch. As for new workflow, process fails with old one because seems like it tries to use input/output variables which can't be used when they are absent in process. I pointed it in https://hortonworks.jira.com/browse/BUG-21824.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/#review52653
-----------------------------------------------------------
On Sept. 9, 2014, 3:13 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25446/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 3:13 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-693
> https://issues.apache.org/jira/browse/FALCON-693
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tests with zero inp/outp fixed to use correct workflow, javadocs added
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 638768d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 9c71375
>
> Diff: https://reviews.apache.org/r/25446/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed
to use correct workflow, javadocs added
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/#review52653
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java
<https://reviews.apache.org/r/25446/#comment91532>
Why have we changed the workflow that was being used ? And in case we want to do that then we can get rid of aggregateWorkflowDir field.
- Raghav Gautam
On Sept. 8, 2014, 9:31 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25446/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2014, 9:31 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-693
> https://issues.apache.org/jira/browse/FALCON-693
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tests with zero inp/outp fixed to use correct workflow, javadocs added
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 638768d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 1225525
>
> Diff: https://reviews.apache.org/r/25446/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed
to use correct workflow, javadocs added
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/#review53131
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Sept. 9, 2014, 8:13 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25446/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 8:13 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-693
> https://issues.apache.org/jira/browse/FALCON-693
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tests with zero inp/outp fixed to use correct workflow, javadocs added
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 638768d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 9c71375
>
> Diff: https://reviews.apache.org/r/25446/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed
to use correct workflow, javadocs added
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/
-----------------------------------------------------------
(Updated Sept. 9, 2014, 3:13 p.m.)
Review request for Falcon.
Changes
-------
unsused variable removed
Bugs: FALCON-693
https://issues.apache.org/jira/browse/FALCON-693
Repository: falcon-git
Description
-------
Tests with zero inp/outp fixed to use correct workflow, javadocs added
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 638768d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 9c71375
Diff: https://reviews.apache.org/r/25446/diff/
Testing
-------
Tested.
Thanks,
Paul Isaychuk
Re: Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed
to use correct workflow, javadocs added
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/
-----------------------------------------------------------
(Updated Sept. 9, 2014, 3:12 p.m.)
Review request for Falcon.
Changes
-------
unused variable removed
Bugs: FALCON-693
https://issues.apache.org/jira/browse/FALCON-693
Repository: falcon-git
Description
-------
Tests with zero inp/outp fixed to use correct workflow, javadocs added
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 638768d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 9c71375
Diff: https://reviews.apache.org/r/25446/diff/
Testing
-------
Tested.
Thanks,
Paul Isaychuk