[jira] [Commented] (SHINDIG-1873) Incorrectly parsed moduleId in TokenRequestData

["Ryan Baxter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458675#comment-13458675 ] 

Ryan Baxter commented on SHINDIG-1873:
--------------------------------------

Matt thanks for the patch!  Can you create a review at reviews.apache.org and add the shindig community as a reviewer?  I would like you to get some kudos for submitting the patch.  Thanks.
                
> Incorrectly parsed moduleId in TokenRequestData
> -----------------------------------------------
>
>                 Key: SHINDIG-1873
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1873
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.5.0-beta4
>            Reporter: Matt Jones
>         Attachments: fix-SHINDIG-1873-bug.patch
>
>
> When a gadgets:token RPC request is made the gadget's module ID is encoded with the gadget's URL in the form:
> [gadget URL]#[module ID] (features/src/main/javascript/features/container.util/util.js line 191)
> However, when the module ID is parsed out by the container, it seems to expect it in the form:
> [gadget URL]#moduleId=[moduleId] (GadgetsHandler.TokenRequestData, line 575)
> This means moduleId is never parsed and the RPC request always returns a moduleId of zero.
> The comment above the container code seems to imply that the JS encoding is correct and therefore the container's code is at fault.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira