You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Mladen Turk <mt...@mappingsoft.com> on 2001/11/20 12:18:19 UTC
[PATCH] mpm_winnt -- check for connection and then update context
Hi,
The WIN2K and WINXP logs something like :
(32557)Socket is not connected: setsockopt(SO_UPDATE_ACCEPT_CONTEXT)
failed.
For almost each connection made.
Although this is not a fatal error, the setsockopt has no sense on the
socket that hasn't been accepted.
The patch calls the getsockopt and checks whether a connection has been
accepted and then calls the setsockopt to set the
SO_UPDATE_ACCEPT_CONTEXT.
MT.
RE: [PATCH] mpm_winnt -- check for connection and then update context
Posted by Mladen Turk <mt...@mappingsoft.com>.
> -----Original Message-----
> From: Bill Stoddard [mailto:bill@wstoddard.com]
> Sent: Tuesday, November 20, 2001 4:27 PM
> To: dev@httpd.apache.org; mturk@mappingsoft.com
> Subject: Re: [PATCH] mpm_winnt -- check for connection and then
> update context
>
>
> I believe the attached patch is a better solution. The
> setsockopt(SO_UPDATE_ACCEPT_CONTEXT) needs to be issued on the
> socket once the socket has
> been accepted (after AcceptEx, not before). There is an
> optimization to not call
> setsockopt on accept sockets that are being reused but I'll worry
> about that later. Let me
> know how this patch works.
>
> Bill
It does.
Actually that was the first thing I've tried ;-)
MT.
Re: [PATCH] mpm_winnt -- check for connection and then update context
Posted by Bill Stoddard <bi...@wstoddard.com>.
I believe the attached patch is a better solution. The
setsockopt(SO_UPDATE_ACCEPT_CONTEXT) needs to be issued on the socket once the socket has
been accepted (after AcceptEx, not before). There is an optimization to not call
setsockopt on accept sockets that are being reused but I'll worry about that later. Let me
know how this patch works.
Bill
----- Original Message -----
From: "Mladen Turk" <mt...@mappingsoft.com>
To: <de...@httpd.apache.org>
Sent: Tuesday, November 20, 2001 6:18 AM
Subject: [PATCH] mpm_winnt -- check for connection and then update context
> Hi,
>
> The WIN2K and WINXP logs something like :
> (32557)Socket is not connected: setsockopt(SO_UPDATE_ACCEPT_CONTEXT)
> failed.
> For almost each connection made.
>
> Although this is not a fatal error, the setsockopt has no sense on the
> socket that hasn't been accepted.
> The patch calls the getsockopt and checks whether a connection has been
> accepted and then calls the setsockopt to set the
> SO_UPDATE_ACCEPT_CONTEXT.
>
> MT.
>
Re: [PATCH] mpm_winnt -- check for connection and then update context
Posted by Ryan Bloom <rb...@covalent.net>.
On Tuesday 20 November 2001 05:40 am, Bill Stoddard wrote:
Can I ask why? I get these errors all the time on my XP machine, and they
have really been bothering me.
Ryan
> I don't see this message on Win2k but I'll spend a bit of time looking at
> the code. In the meantime, I am -1 on this patch.
>
> Bill
>
> ----- Original Message -----
> From: "Mladen Turk" <mt...@mappingsoft.com>
> To: <de...@httpd.apache.org>
> Sent: Tuesday, November 20, 2001 6:18 AM
> Subject: [PATCH] mpm_winnt -- check for connection and then update context
>
> > Hi,
> >
> > The WIN2K and WINXP logs something like :
> > (32557)Socket is not connected: setsockopt(SO_UPDATE_ACCEPT_CONTEXT)
> > failed.
> > For almost each connection made.
> >
> > Although this is not a fatal error, the setsockopt has no sense on the
> > socket that hasn't been accepted.
> > The patch calls the getsockopt and checks whether a connection has been
> > accepted and then calls the setsockopt to set the
> > SO_UPDATE_ACCEPT_CONTEXT.
> >
> > MT.
--
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
RE: [PATCH] mpm_winnt -- check for connection and then update context
Posted by Mladen Turk <mt...@mappingsoft.com>.
> -----Original Message-----
> From: Bill Stoddard [mailto:bill@wstoddard.com]
> Sent: Tuesday, November 20, 2001 2:41 PM
> To: dev@httpd.apache.org; mturk@mappingsoft.com
> Subject: Re: [PATCH] mpm_winnt -- check for connection and then
> update context
>
>
> I don't see this message on Win2k but I'll spend a bit of time
> looking at the code. In the
> meantime, I am -1 on this patch.
Try to set the LogLevel warn :-)
> Bill
>
> ----- Original Message -----
> From: "Mladen Turk" <mt...@mappingsoft.com>
> To: <de...@httpd.apache.org>
> Sent: Tuesday, November 20, 2001 6:18 AM
> Subject: [PATCH] mpm_winnt -- check for connection and then update context
>
>
> > Hi,
> >
> > The WIN2K and WINXP logs something like :
> > (32557)Socket is not connected: setsockopt(SO_UPDATE_ACCEPT_CONTEXT)
> > failed.
> > For almost each connection made.
> >
> > Although this is not a fatal error, the setsockopt has no sense on the
> > socket that hasn't been accepted.
> > The patch calls the getsockopt and checks whether a connection has been
> > accepted and then calls the setsockopt to set the
> > SO_UPDATE_ACCEPT_CONTEXT.
> >
> > MT.
> >
>
>
>
Re: [PATCH] mpm_winnt -- check for connection and then update context
Posted by Bill Stoddard <bi...@wstoddard.com>.
I don't see this message on Win2k but I'll spend a bit of time looking at the code. In the
meantime, I am -1 on this patch.
Bill
----- Original Message -----
From: "Mladen Turk" <mt...@mappingsoft.com>
To: <de...@httpd.apache.org>
Sent: Tuesday, November 20, 2001 6:18 AM
Subject: [PATCH] mpm_winnt -- check for connection and then update context
> Hi,
>
> The WIN2K and WINXP logs something like :
> (32557)Socket is not connected: setsockopt(SO_UPDATE_ACCEPT_CONTEXT)
> failed.
> For almost each connection made.
>
> Although this is not a fatal error, the setsockopt has no sense on the
> socket that hasn't been accepted.
> The patch calls the getsockopt and checks whether a connection has been
> accepted and then calls the setsockopt to set the
> SO_UPDATE_ACCEPT_CONTEXT.
>
> MT.
>