You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Kinga Marton via Review Board <no...@reviews.apache.org> on 2018/07/22 13:16:58 UTC
Review Request 68008: OOZIE-2942 [examples] Fix Findbugs warnings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68008/
-----------------------------------------------------------
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Currently Findbugs complains about the following warnings in the oozie-examples module:
```
[INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close stream on exception [org.apache.oozie.example.DateList] At DateList.java:[line 69]
[INFO] Nullcheck of date at line 55 of value previously dereferenced in org.apache.oozie.example.DateList.main(String[]) [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
[INFO] Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called [org.apache.oozie.example.DateList] At DateList.java:[line 97]
[INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource created at LocalOozieExample.java:[line 72] is not dischargedPath continues at LocalOozieExample.java:[line 76]Path continues at LocalOozieExample.java:[line 77]Path continues at LocalOozieExample.java:[line 78]Path continues at LocalOozieExample.java:[line 81]Path continues at LocalOozieExample.java:[line 88]Path continues at LocalOozieExample.java:[line 89]Path continues at LocalOozieExample.java:[line 91]Path continues at LocalOozieExample.java:[line 10
0]
[INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to close stream [org.apache.oozie.example.LocalOozieExample] At LocalOozieExample.java:[line 72]
[INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal representation by returning Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
[INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose internal representation by storing an externally mutable object into Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 172]
```
They should be fixed to get the code more reliable.
Diffs
-----
examples/src/main/java/org/apache/oozie/example/DateList.java 7e574cbe
examples/src/main/java/org/apache/oozie/example/LocalOozieExample.java c9f5697c
examples/src/main/java/org/apache/oozie/example/Repeatable.java ee863251
Diff: https://reviews.apache.org/r/68008/diff/1/
Testing
-------
Thanks,
Kinga Marton
Re: Review Request 68008: OOZIE-2942 [examples] Fix Findbugs warnings
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68008/#review206650
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On July 22, 2018, 1:16 p.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68008/
> -----------------------------------------------------------
>
> (Updated July 22, 2018, 1:16 p.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Currently Findbugs complains about the following warnings in the oozie-examples module:
> ```
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close stream on exception [org.apache.oozie.example.DateList] At DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in org.apache.oozie.example.DateList.main(String[]) [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource created at LocalOozieExample.java:[line 72] is not dischargedPath continues at LocalOozieExample.java:[line 76]Path continues at LocalOozieExample.java:[line 77]Path continues at LocalOozieExample.java:[line 78]Path continues at LocalOozieExample.java:[line 81]Path continues at LocalOozieExample.java:[line 88]Path continues at LocalOozieExample.java:[line 89]Path continues at LocalOozieExample.java:[line 91]Path continues at LocalOozieExample.java:[line
100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to close stream [org.apache.oozie.example.LocalOozieExample] At LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal representation by returning Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose internal representation by storing an externally mutable object into Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 172]
> ```
>
> They should be fixed to get the code more reliable.
>
>
> Diffs
> -----
>
> examples/src/main/java/org/apache/oozie/example/DateList.java 7e574cbe
> examples/src/main/java/org/apache/oozie/example/LocalOozieExample.java c9f5697c
> examples/src/main/java/org/apache/oozie/example/Repeatable.java ee863251
>
>
> Diff: https://reviews.apache.org/r/68008/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kinga Marton
>
>