You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Doğacan Güney (JIRA)" <ji...@apache.org> on 2009/07/11 13:27:14 UTC
[jira] Created: (HBASE-1646) Scan-s can't set a Filter
Scan-s can't set a Filter
-------------------------
Key: HBASE-1646
URL: https://issues.apache.org/jira/browse/HBASE-1646
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: Doğacan Güney
Scan#write:
{code}
HbaseObjectWritable.writeObject(out, this.filter, Filter.class, null);
{code}
Because of the third argument (Filter.class), HbaseObjectWritable can not write or read the filter (as Filter is not instantiable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1646) Scan-s can't set a Filter
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated HBASE-1646:
---------------------------------
Attachment: scan.patch
You can just change third arg to this.filter.getClass() too. But using HbaseObjectWritable, you can not write your own classes as HOW throws exception if you give it a class that in not in its map.
This patch instead just reads/writes the full class name.
> Scan-s can't set a Filter
> -------------------------
>
> Key: HBASE-1646
> URL: https://issues.apache.org/jira/browse/HBASE-1646
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Doğacan Güney
> Attachments: scan.patch
>
>
> Scan#write:
> {code}
> HbaseObjectWritable.writeObject(out, this.filter, Filter.class, null);
> {code}
> Because of the third argument (Filter.class), HbaseObjectWritable can not write or read the filter (as Filter is not instantiable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1646) Scan-s can't set a Filter
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated HBASE-1646:
---------------------------------
Attachment: HBASE-1646-v2.patch
Patch updated to use Bytes.{read,write}ByteArray instead of Text methods.
> Scan-s can't set a Filter
> -------------------------
>
> Key: HBASE-1646
> URL: https://issues.apache.org/jira/browse/HBASE-1646
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Doğacan Güney
> Attachments: HBASE-1646-v2.patch, scan.patch
>
>
> Scan#write:
> {code}
> HbaseObjectWritable.writeObject(out, this.filter, Filter.class, null);
> {code}
> Because of the third argument (Filter.class), HbaseObjectWritable can not write or read the filter (as Filter is not instantiable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1646) Scan-s can't set a Filter
Posted by "Erik Holstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730118#action_12730118 ]
Erik Holstad commented on HBASE-1646:
-------------------------------------
Do you think you can name the patches something like HBASE-1646-v1.patch in the future, just to keep it easy to track?
Regards Erik
> Scan-s can't set a Filter
> -------------------------
>
> Key: HBASE-1646
> URL: https://issues.apache.org/jira/browse/HBASE-1646
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Doğacan Güney
> Attachments: scan.patch
>
>
> Scan#write:
> {code}
> HbaseObjectWritable.writeObject(out, this.filter, Filter.class, null);
> {code}
> Because of the third argument (Filter.class), HbaseObjectWritable can not write or read the filter (as Filter is not instantiable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1646) Scan-s can't set a Filter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1646.
--------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
Committed. Thanks for the patch Doğacan Güney. I added to the Scan serialization a test for a Scan carrying a filter. This patch is doubly good in that it removes the new HBaseConfiguration that was done inside in the HOW serializing.
> Scan-s can't set a Filter
> -------------------------
>
> Key: HBASE-1646
> URL: https://issues.apache.org/jira/browse/HBASE-1646
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Doğacan Güney
> Fix For: 0.20.0
>
> Attachments: HBASE-1646-v2.patch, scan.patch
>
>
> Scan#write:
> {code}
> HbaseObjectWritable.writeObject(out, this.filter, Filter.class, null);
> {code}
> Because of the third argument (Filter.class), HbaseObjectWritable can not write or read the filter (as Filter is not instantiable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1646) Scan-s can't set a Filter
Posted by "Erik Holstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730117#action_12730117 ]
Erik Holstad commented on HBASE-1646:
-------------------------------------
Hey Doĝacan.
I think we are trying to move away from the use of the Text class, maybe you can use ImmutableBytesWritable or something like that instead?
Regards Erik
> Scan-s can't set a Filter
> -------------------------
>
> Key: HBASE-1646
> URL: https://issues.apache.org/jira/browse/HBASE-1646
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Doğacan Güney
> Attachments: scan.patch
>
>
> Scan#write:
> {code}
> HbaseObjectWritable.writeObject(out, this.filter, Filter.class, null);
> {code}
> Because of the third argument (Filter.class), HbaseObjectWritable can not write or read the filter (as Filter is not instantiable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.