You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/01 06:55:16 UTC
[GitHub] [flink] ZhijieYang opened a new pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
ZhijieYang opened a new pull request #16337:
URL: https://github.com/apache/flink/pull/16337
## What is the purpose of the change
code: https://github.com/apache/flink/blob/abd321c04d87799800d0b0dada9334fd46f99960/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/options/HBaseOptions.java#L103
docment: https://github.com/apache/flink/blob/master/docs/content/docs/connectors/table/hbase.md#lookupcachemax-rows
The type of configuration `lookup.cache.max-rows` should be Long instead of Integer and the defaule value is wrong also.
## Brief change log
Document and code are inconsistent.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`:no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-880365624
> > @leonardBang Hi, This is my first time contribute code, so some of the processes are not clear to me yet. Wait for the build means I don't need to do anything else and the flinkbot will build automatically, or I need to build manually and then request merge
>
> HI, @ZhijieYang Flink community requires all PR could merge until the CI tests passed, both every new commit and `@flinkbot run azure` will trigger the CI， we just need to wait the CI passed when we add a new commit. If it not works, we can then call `@flinkbot run azure` to trigger the CI manually
Thanks a lot @leonardBang
Best wishes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efe932f6929c3e25457ddd40872fa33427ed6c3f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efe932f6929c3e25457ddd40872fa33427ed6c3f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #16337:
URL: https://github.com/apache/flink/pull/16337#discussion_r669321360
##########
File path: docs/content/docs/connectors/table/hbase.md
##########
@@ -176,14 +176,14 @@ Connector Options
<tr>
<td><h5>lookup.cache.max-rows</h5></td>
<td>optional</td>
- <td style="word-wrap: break-word;">(none)</td>
- <td>Integer</td>
+ <td style="word-wrap: break-word;">-1</td>
+ <td>Long</td>
<td>The max number of rows of lookup cache, over this value, the oldest rows will be expired. Note, "lookup.cache.max-rows" and "lookup.cache.ttl" options must all be specified if any of them is specified. Lookup cache is disabled by default.</td>
</tr>
<tr>
<td><h5>lookup.cache.ttl</h5></td>
<td>optional</td>
- <td style="word-wrap: break-word;">(none)</td>
+ <td style="word-wrap: break-word;">0</td>
Review comment:
Should be `0 s` for `Duration` type
```suggestion
<td style="word-wrap: break-word;">0 s</td>
```
##########
File path: docs/content.zh/docs/connectors/table/hbase.md
##########
@@ -169,14 +169,14 @@ ON myTopic.key = hTable.rowkey;
<tr>
<td><h5>lookup.cache.max-rows</h5></td>
<td>可选</td>
- <td style="word-wrap: break-word;">(无)</td>
- <td>Integer</td>
+ <td style="word-wrap: break-word;">-1</td>
+ <td>Long</td>
<td>查找缓存的最大行数，超过这个值，最旧的行将过期。注意："lookup.cache.max-rows" 和 "lookup.cache.ttl" 必须同时被设置。默认情况下，查找缓存是禁用的。 </td>
</tr>
<tr>
<td><h5>lookup.cache.ttl</h5></td>
<td>可选</td>
- <td style="word-wrap: break-word;">(无)</td>
+ <td style="word-wrap: break-word;">0</td>
Review comment:
Should be `0 s` for `Duration` type
```suggestion
<td style="word-wrap: break-word;">0 s</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-879613775
@leonardBang @JingsongLi Hi, can you review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871978011
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b7d78128ac4f1d7b8fa086c82748439928a10fee (Tue Dec 14 09:05:08 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efe932f6929c3e25457ddd40872fa33427ed6c3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-873723443
Hi, can you review it? thanks, @klion26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-879659637
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880365624",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20464)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-880345578
@leonardBang Hi, This is my first time contribute code, so some of the processes are not clear to me yet. Wait for the build means I don't need to do anything else and the flinkbot will build automatically, or I need to build manually and then request merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* efe932f6929c3e25457ddd40872fa33427ed6c3f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764)
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efe932f6929c3e25457ddd40872fa33427ed6c3f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764)
* b7d78128ac4f1d7b8fa086c82748439928a10fee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "880345922",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462",
"triggerID" : "880363807",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20461) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #16337:
URL: https://github.com/apache/flink/pull/16337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871978011
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit efe932f6929c3e25457ddd40872fa33427ed6c3f (Thu Jul 01 06:57:53 UTC 2021)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-22843).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-880345922
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-880363807
> @leonardBang Hi, This is my first time contribute code, so some of the processes are not clear to me yet. Wait for the build means I don't need to do anything else and the flinkbot will build automatically, or I need to build manually and then request merge
HI, @ZhijieYang Flink community requires all PR could merge until the CI tests passed, both every new commit and `@flinkbot run azure` will trigger the CI， we just need to wait the CI passed when we add a new commit. If it not works, we can then call `@flinkbot run azure` to trigger the CI manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-871994148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19764",
"triggerID" : "efe932f6929c3e25457ddd40872fa33427ed6c3f",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"triggerType" : "PUSH"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
}, {
"hash" : "b7d78128ac4f1d7b8fa086c82748439928a10fee",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417",
"triggerID" : "879659637",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b7d78128ac4f1d7b8fa086c82748439928a10fee Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20419) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhijieYang commented on pull request #16337: [FLINK-22843][docs-zh]Document and code are inconsistent.
Posted by GitBox <gi...@apache.org>.
ZhijieYang commented on pull request #16337:
URL: https://github.com/apache/flink/pull/16337#issuecomment-879634300
@leonardBang Hi, I have done it follows your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org