You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/28 07:49:01 UTC
[GitHub] [flink] fapaul opened a new pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
fapaul opened a new pull request #17367:
URL: https://github.com/apache/flink/pull/17367
…or to allow sinks emitting a flexible number of records
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Initially, we assumed every incoming record of a sink creates one
outgoing record after SinkWriter#write is called. This is not correct
for all sinks thus the SinkWriter should now increment the counter
accordingly.
## Brief change log
- Expose recordsOut metric in SinkWriters and increment it in existing ones (FileWriter, KafkaWriter)
## Verifying this change
- Added 2 two tests for KafkaWriter and FileWriter verifying the counter is incremented.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17367:
URL: https://github.com/apache/flink/pull/17367#discussion_r721306027
##########
File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/writer/FileWriter.java
##########
@@ -85,17 +86,21 @@
private final OutputFileConfig outputFileConfig;
+ private final Counter recordsOutCounter;
+
/**
* A constructor creating a new empty bucket manager.
*
* @param basePath The base path for our buckets.
+ * @param recordsOutCounter denoting the number records already written
* @param bucketAssigner The {@link BucketAssigner} provided by the user.
* @param bucketFactory The {@link FileWriterBucketFactory} to be used to create buckets.
* @param bucketWriter The {@link BucketWriter} to be used when writing data.
* @param rollingPolicy The {@link RollingPolicy} as specified by the user.
*/
public FileWriter(
final Path basePath,
+ final Counter recordsOutCounter,
Review comment:
I propose to pass the whole metric group instead. We will need it anyways for advanced metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563",
"triggerID" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ee22fc68368972162785a3d390b0d39bfe0cfd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ee22fc68368972162785a3d390b0d39bfe0cfd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563",
"triggerID" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ee22fc68368972162785a3d390b0d39bfe0cfd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563",
"triggerID" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"triggerType" : "PUSH"
}, {
"hash" : "4b7b71d970d59d2efff9754d2e8b081d572ae590",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b7b71d970d59d2efff9754d2e8b081d572ae590",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ee22fc68368972162785a3d390b0d39bfe0cfd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563)
* 4b7b71d970d59d2efff9754d2e8b081d572ae590 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928944825
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 82ee22fc68368972162785a3d390b0d39bfe0cfd (Tue Sep 28 07:51:48 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24382).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563",
"triggerID" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"triggerType" : "PUSH"
}, {
"hash" : "4b7b71d970d59d2efff9754d2e8b081d572ae590",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24777",
"triggerID" : "4b7b71d970d59d2efff9754d2e8b081d572ae590",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b7b71d970d59d2efff9754d2e8b081d572ae590 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928944825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17367:
URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563",
"triggerID" : "82ee22fc68368972162785a3d390b0d39bfe0cfd",
"triggerType" : "PUSH"
}, {
"hash" : "4b7b71d970d59d2efff9754d2e8b081d572ae590",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24777",
"triggerID" : "4b7b71d970d59d2efff9754d2e8b081d572ae590",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ee22fc68368972162785a3d390b0d39bfe0cfd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24563)
* 4b7b71d970d59d2efff9754d2e8b081d572ae590 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #17367:
URL: https://github.com/apache/flink/pull/17367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org