You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2008/08/25 21:41:44 UTC

[jira] Created: (PIG-398) Expressions not allowed inside foreach

Expressions not allowed inside foreach
--------------------------------------

                 Key: PIG-398
                 URL: https://issues.apache.org/jira/browse/PIG-398
             Project: Pig
          Issue Type: Bug
            Reporter: Olga Natkovich
            Assignee: Santhosh Srinivasan


The following used to work but no longer does:

A = load 'data';
B = group A by $0;
C = foreach B{
   D = MAX(A.$0)
   generate D;
}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-398) Expressions not allowed inside foreach

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-398:
-------------------------------

        Fix Version/s: types_branch
    Affects Version/s: types_branch

> Expressions not allowed inside foreach
> --------------------------------------
>
>                 Key: PIG-398
>                 URL: https://issues.apache.org/jira/browse/PIG-398
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>
> The following used to work but no longer does:
> A = load 'data';
> B = group A by $0;
> C = foreach B{
>    D = MAX(A.$0)
>    generate D;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-398) Expressions not allowed inside foreach

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich resolved PIG-398.
--------------------------------

    Resolution: Fixed

patch committed. thanks santhosh!

> Expressions not allowed inside foreach
> --------------------------------------
>
>                 Key: PIG-398
>                 URL: https://issues.apache.org/jira/browse/PIG-398
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>         Attachments: Pig-398.patch, Pig-398_1.patch
>
>
> The following used to work but no longer does:
> A = load 'data';
> B = group A by $0;
> C = foreach B{
>    D = MAX(A.$0)
>    generate D;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-398) Expressions not allowed inside foreach

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santhosh Srinivasan updated PIG-398:
------------------------------------

    Attachment: Pig-398_1.patch

Updated patch after streaming was fixed as part of Pig-269.

Unit tests that still fail are:

    [junit] Running org.apache.pig.test.TestBuiltin
    [junit] Tests run: 23, Failures: 1, Errors: 2, Time elapsed: 14.622 sec
    [junit] Test org.apache.pig.test.TestBuiltin FAILED

    [junit] Running org.apache.pig.test.TestEvalPipeline
    [junit] Tests run: 10, Failures: 1, Errors: 0, Time elapsed: 353.427 sec
    [junit] Test org.apache.pig.test.TestEvalPipeline FAILED

    [junit] Running org.apache.pig.test.TestMRCompiler
    [junit] Tests run: 16, Failures: 1, Errors: 0, Time elapsed: 0.422 sec
    [junit] Test org.apache.pig.test.TestMRCompiler FAILED

> Expressions not allowed inside foreach
> --------------------------------------
>
>                 Key: PIG-398
>                 URL: https://issues.apache.org/jira/browse/PIG-398
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>         Attachments: Pig-398.patch, Pig-398_1.patch
>
>
> The following used to work but no longer does:
> A = load 'data';
> B = group A by $0;
> C = foreach B{
>    D = MAX(A.$0)
>    generate D;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (PIG-398) Expressions not allowed inside foreach

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628506#action_12628506 ] 

sms edited comment on PIG-398 at 9/4/08 3:51 PM:
-----------------------------------------------------------------

Updated patch (Pig-398_1.patch) after streaming was fixed as part of Pig-269.

Unit tests that still fail are:

    [junit] Running org.apache.pig.test.TestBuiltin
    [junit] Tests run: 23, Failures: 1, Errors: 2, Time elapsed: 14.622 sec
    [junit] Test org.apache.pig.test.TestBuiltin FAILED

    [junit] Running org.apache.pig.test.TestEvalPipeline
    [junit] Tests run: 10, Failures: 1, Errors: 0, Time elapsed: 353.427 sec
    [junit] Test org.apache.pig.test.TestEvalPipeline FAILED

    [junit] Running org.apache.pig.test.TestMRCompiler
    [junit] Tests run: 16, Failures: 1, Errors: 0, Time elapsed: 0.422 sec
    [junit] Test org.apache.pig.test.TestMRCompiler FAILED

      was (Author: sms):
    Updated patch after streaming was fixed as part of Pig-269.

Unit tests that still fail are:

    [junit] Running org.apache.pig.test.TestBuiltin
    [junit] Tests run: 23, Failures: 1, Errors: 2, Time elapsed: 14.622 sec
    [junit] Test org.apache.pig.test.TestBuiltin FAILED

    [junit] Running org.apache.pig.test.TestEvalPipeline
    [junit] Tests run: 10, Failures: 1, Errors: 0, Time elapsed: 353.427 sec
    [junit] Test org.apache.pig.test.TestEvalPipeline FAILED

    [junit] Running org.apache.pig.test.TestMRCompiler
    [junit] Tests run: 16, Failures: 1, Errors: 0, Time elapsed: 0.422 sec
    [junit] Test org.apache.pig.test.TestMRCompiler FAILED
  
> Expressions not allowed inside foreach
> --------------------------------------
>
>                 Key: PIG-398
>                 URL: https://issues.apache.org/jira/browse/PIG-398
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>         Attachments: Pig-398.patch, Pig-398_1.patch
>
>
> The following used to work but no longer does:
> A = load 'data';
> B = group A by $0;
> C = foreach B{
>    D = MAX(A.$0)
>    generate D;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-398) Expressions not allowed inside foreach

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santhosh Srinivasan updated PIG-398:
------------------------------------

    Attachment: Pig-398.patch

Patch, Pig-398.patch fixes the following:

1. Expression assignment within foreach is now re-instated
2. Visit methods for operators that contain nested plans in LOVisitor are fixed. Previously only the roots of the nested plans were visited.
3. Cast field schemas will no longer be reset during optimization
4. History will now persist across multiple pig interactive sessions - thanks to Raghotham S Murthy from Facebook.

Unit tests that still fail are:

    [junit] Running org.apache.pig.test.TestBuiltin
    [junit] Tests run: 23, Failures: 1, Errors: 2, Time elapsed: 14.363 sec
    [junit] Test org.apache.pig.test.TestBuiltin FAILED

    [junit] Running org.apache.pig.test.TestEvalPipeline
    [junit] Tests run: 10, Failures: 1, Errors: 0, Time elapsed: 163.484 sec
    [junit] Test org.apache.pig.test.TestEvalPipeline FAILED

    [junit] Running org.apache.pig.test.TestMRCompiler
    [junit] Tests run: 16, Failures: 1, Errors: 0, Time elapsed: 0.24 sec
    [junit] Test org.apache.pig.test.TestMRCompiler FAILED

> Expressions not allowed inside foreach
> --------------------------------------
>
>                 Key: PIG-398
>                 URL: https://issues.apache.org/jira/browse/PIG-398
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>         Attachments: Pig-398.patch
>
>
> The following used to work but no longer does:
> A = load 'data';
> B = group A by $0;
> C = foreach B{
>    D = MAX(A.$0)
>    generate D;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-398) Expressions not allowed inside foreach

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santhosh Srinivasan updated PIG-398:
------------------------------------

    Patch Info: [Patch Available]

> Expressions not allowed inside foreach
> --------------------------------------
>
>                 Key: PIG-398
>                 URL: https://issues.apache.org/jira/browse/PIG-398
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>         Attachments: Pig-398.patch
>
>
> The following used to work but no longer does:
> A = load 'data';
> B = group A by $0;
> C = foreach B{
>    D = MAX(A.$0)
>    generate D;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.