[GitHub] [incubator-superset] willbarrett commented on pull request #10128: fix: [search query view] edit link is broken

[GitBox <gi...@apache.org>]

willbarrett commented on pull request #10128:
URL: https://github.com/apache/incubator-superset/pull/10128#issuecomment-648983543


   As you mention, extending the QueryView to retain the existing interface is simple - my vote would be to do that in this PR, then introduce another PR that changes the external API. I worry that a fix PR removing a publicly-available API won't receive the right level of scrutiny from organizations that might be leveraging it, and may be reverted later on.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org