You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by wr...@apache.org on 2007/10/15 05:55:13 UTC
svn commit: r584663 - /apr/apr/trunk/test/testsockets.c
Author: wrowe
Date: Sun Oct 14 20:55:13 2007
New Revision: 584663
URL: http://svn.apache.org/viewvc?rev=584663&view=rev
Log:
reset the fail flag or we cannot see consecutive failures. We are
interested in the original failure, as well as which section was
invoked when it failed.
Modified:
apr/apr/trunk/test/testsockets.c
Modified: apr/apr/trunk/test/testsockets.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/test/testsockets.c?rev=584663&r1=584662&r2=584663&view=diff
==============================================================================
--- apr/apr/trunk/test/testsockets.c (original)
+++ apr/apr/trunk/test/testsockets.c Sun Oct 14 20:55:13 2007
@@ -164,15 +164,19 @@
static void sendto_receivefrom(abts_case *tc, void *data)
{
+ int failed;
sendto_receivefrom_helper(tc, "127.0.0.1", "127.1.2.3", APR_INET);
- ABTS_TRUE(tc, !tc->failed);
+ failed = tc->failed; failed = 0;
+ ABTS_TRUE(tc, failed);
}
#if APR_HAVE_IPV6
static void sendto_receivefrom6(abts_case *tc, void *data)
{
+ int failed;
sendto_receivefrom_helper(tc, "::1", "FA0E::1234:127.1.2.3", APR_INET6);
- ABTS_TRUE(tc, !tc->failed);
+ failed = tc->failed; failed = 0;
+ ABTS_TRUE(tc, failed);
}
#endif
Re: svn commit: r584663 - /apr/apr/trunk/test/testsockets.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Lucian Adrian Grijincu wrote:
>
> may I ask why you do
> failed = tc->failed; failed = 0; ?
Because I was an idiot - nice catch, thanks :)
Re: svn commit: r584663 - /apr/apr/trunk/test/testsockets.c
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On 10/15/07, wrowe@apache.org <wr...@apache.org> wrote:
> Author: wrowe
> Date: Sun Oct 14 20:55:13 2007
> New Revision: 584663
>
> URL: http://svn.apache.org/viewvc?rev=584663&view=rev
> Log:
> reset the fail flag or we cannot see consecutive failures. We are
> interested in the original failure, as well as which section was
> invoked when it failed.
>
> Modified:
> apr/apr/trunk/test/testsockets.c
>
> Modified: apr/apr/trunk/test/testsockets.c
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/test/testsockets.c?rev=584663&r1=584662&r2=584663&view=diff
> ==============================================================================
> --- apr/apr/trunk/test/testsockets.c (original)
> +++ apr/apr/trunk/test/testsockets.c Sun Oct 14 20:55:13 2007
> @@ -164,15 +164,19 @@
>
> static void sendto_receivefrom(abts_case *tc, void *data)
> {
> + int failed;
> sendto_receivefrom_helper(tc, "127.0.0.1", "127.1.2.3", APR_INET);
> - ABTS_TRUE(tc, !tc->failed);
> + failed = tc->failed; failed = 0;
may I ask why you do
failed = tc->failed; failed = 0; ?
> + ABTS_TRUE(tc, failed);
> }
>
> #if APR_HAVE_IPV6
> static void sendto_receivefrom6(abts_case *tc, void *data)
> {
> + int failed;
> sendto_receivefrom_helper(tc, "::1", "FA0E::1234:127.1.2.3", APR_INET6);
> - ABTS_TRUE(tc, !tc->failed);
> + failed = tc->failed; failed = 0;
> + ABTS_TRUE(tc, failed);
> }
> #endif
>
>
>
>