You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/08/09 10:11:45 UTC

[GitHub] zeppelin pull request #3120: ZEPPELIN-3697. Remove interpreter completion fo...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/3120

    ZEPPELIN-3697. Remove interpreter completion for magic part

    ### What is this PR for?
    Trivial PR to remove interpreter completion for magic part. Code completion is sufficient for users, I don't think user use code completion for magic part (repl name). 
    
    
    ### What type of PR is it?
    [ Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3697
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3697

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3120
    
----
commit a488dc7b978f53a0e3668d5189b773d4c11f20ec
Author: Jeff Zhang <zj...@...>
Date:   2018-08-09T07:27:55Z

    ZEPPELIN-3697. Remove interpreter completion for magic part

----


---

[GitHub] zeppelin issue #3120: ZEPPELIN-3697. Remove interpreter completion for magic...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3120
  
    Thanks @jongyoul will do that, actually the interpreter completion never works, I don't think people used it before. 


---

[GitHub] zeppelin pull request #3120: ZEPPELIN-3697. Remove interpreter completion fo...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3120


---

[GitHub] zeppelin issue #3120: ZEPPELIN-3697. Remove interpreter completion for magic...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3120
  
    Agreed. BTW, I think we'd better leave comments when releasing a new version.


---

[GitHub] zeppelin issue #3120: ZEPPELIN-3697. Remove interpreter completion for magic...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3120
  
    @felixcheung @jongyoul Could you help review it ? Thanks


---