You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MaxGekk <gi...@git.apache.org> on 2018/07/07 15:59:11 UTC
[GitHub] spark pull request #21727: [SPARK-24757][SQL] Improving the error message fo...
GitHub user MaxGekk opened a pull request:
https://github.com/apache/spark/pull/21727
[SPARK-24757][SQL] Improving the error message for broadcast timeouts
## What changes were proposed in this pull request?
In the PR, I propose to provide a tip to user how to resolve the issue of timeout expiration for broadcast joins. In particular, they can increase the timeout via **spark.sql.broadcastTimeout** or disable the broadcast at all by setting **spark.sql.autoBroadcastJoinThreshold** to `-1`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MaxGekk/spark-1 broadcast-timeout-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21727.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21727
----
commit 0d0b3f34a90469ba894a207639456b4b815a90e8
Author: Maxim Gekk <ma...@...>
Date: 2018-07-07T14:46:21Z
Improving the error message for broadcast timeouts
I added a recommendation for increasing broadcast timeout. This sentence is added to existing error message:
```
You can increase the timeout for broadcasts via ${SQLConf.BROADCAST_TIMEOUT.key}
```
Author: Maxim Gekk <ma...@databricks.com>
Closes #2801 from MaxGekk/broadcast-error-message.
commit 86587edca7c1345b8a3687877b598d8389fbd56b
Author: Maxim Gekk <ma...@...>
Date: 2018-07-07T15:57:36Z
Remove empty line in imports
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21727
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21727
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92712/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21727
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21727: [SPARK-24757][SQL] Improving the error message fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21727
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21727
**[Test build #92712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92712/testReport)** for PR 21727 at commit [`86587ed`](https://github.com/apache/spark/commit/86587edca7c1345b8a3687877b598d8389fbd56b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21727
@hvanhovell Please, have a look at the PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21727
Merging to master. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21727
**[Test build #92712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92712/testReport)** for PR 21727 at commit [`86587ed`](https://github.com/apache/spark/commit/86587edca7c1345b8a3687877b598d8389fbd56b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21727: [SPARK-24757][SQL] Improving the error message for broad...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21727
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org