You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/17 17:02:39 UTC
[GitHub] [incubator-devlake] e2corporation opened a new issue, #2762: [Bug][Api] advanced blueprint json response has pascal-case options
e2corporation opened a new issue, #2762:
URL: https://github.com/apache/incubator-devlake/issues/2762
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
Our current API contract in place has agreed to using `camelCase` for all API Response properties instead of `PascalCase`. [GET] for and Advanced Blueprint however certain properties **Plugin** and **Options** for instance, still returns in `PascalCase`. These and possibly other properties need to be changed to `camelCase` for consistency.
:warning: Do Not Fix until AFTER v0.13.0 release!
`Plugin ---> plugin`
`Options ---> options`
```
Summary
URL: http://localhost:4000/api/blueprints/7
Status: 200 OK
Source: Network
Address: 127.0.0.1:4000
Initiator:
xhr.js:187
Request
GET /api/blueprints/7 HTTP/1.1
```
```
{
"name": "ADVANCED BLUEPRINT DevLake",
"mode": "ADVANCED",
"plan": [
[
{
"Plugin": "github",
"Options": {
"repo": "lake",
"owner": "merico-dev",
"connectionId": 1
}
}
]
],
"enable": true,
"cronConfig": "0 0 1 * *",
"isManual": false,
"settings": {
"version": "1.0.0",
"connections": []
},
"id": 7,
"createdAt": "2022-08-02T21:57:42.744Z",
"updatedAt": "2022-08-17T16:59:25.791Z"
}
```
### What you expected to happen
Full API response in `camelCase` for Advanced Blueprints.
### How to reproduce
Fetch and Advanced Blueprint over API.
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2762: [Bug][Api] advanced blueprint json response has pascal-case options
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2762:
URL: https://github.com/apache/incubator-devlake/issues/2762#issuecomment-1220878586
@klesh @mappjzc I think I see part of the problem, our old pipeline config samples are using pascal case (Loading Templates in Advanced Mode). I will have to update the advanced pipeline sample configs to use `camelCase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on issue #2762: [Bug][Api] advanced blueprint json response has pascal-case options
Posted by GitBox <gi...@apache.org>.
mappjzc commented on issue #2762:
URL: https://github.com/apache/incubator-devlake/issues/2762#issuecomment-1220628272
The plugin and the option been saved at the field plan.
And the paln was json.RawMessage
It storages as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed issue #2762: [Bug][Api] advanced blueprint json response has pascal-case options
Posted by GitBox <gi...@apache.org>.
klesh closed issue #2762: [Bug][Api] advanced blueprint json response has pascal-case options
URL: https://github.com/apache/incubator-devlake/issues/2762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on issue #2762: [Bug][Api] advanced blueprint json response has pascal-case options
Posted by GitBox <gi...@apache.org>.
mappjzc commented on issue #2762:
URL: https://github.com/apache/incubator-devlake/issues/2762#issuecomment-1220613598
It seems that I can not reappearance the problem.
My api/blueprint return me this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org