You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/03/25 01:22:31 UTC
[GitHub] [openmeetings] solomax commented on a change in pull request #140: OPENMEETINGS-2601 Able to configure which certificate type to use for WebRtcEndpoint
solomax commented on a change in pull request #140:
URL: https://github.com/apache/openmeetings/pull/140#discussion_r600977472
##########
File path: openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
##########
@@ -112,6 +112,8 @@
private int watchThreadCount = 10;
@Value("${kurento.kuid}")
private String kuid;
+ @Value("${kurento.certificateType}")
+ private String certificateType;
Review comment:
This can be `CertificateKeyType`
put `@Value("${kurento.certificateType}")` on setter
and perform conversion :)
the easy way `CertificateKeyType.valueOf(injectedString)`
##########
File path: openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
##########
@@ -48,8 +49,15 @@ public void release() {
public abstract void release(boolean remove);
- public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline pipeline, Boolean recv) {
+ public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline pipeline, Boolean recv,
Review comment:
this constructor injection is not necessary
##########
File path: openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
##########
@@ -48,8 +49,15 @@ public void release() {
public abstract void release(boolean remove);
- public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline pipeline, Boolean recv) {
+ public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline pipeline, Boolean recv,
+ String certificateType) {
WebRtcEndpoint.Builder builder = new WebRtcEndpoint.Builder(pipeline);
+ // See https://doc-kurento.readthedocs.io/en/latest/features/security.html#media-plane-security-dtls
+ if (CertificateKeyType.RSA.name().equals(certificateType)) {
Review comment:
I would do `if` or `switch` on `kHandler.getCertificateType()` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org