You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/11/22 15:58:00 UTC
[jira] [Commented] (QPID-7892) [Java Broker] Qpid Logback plugin
RollingPolicyDecorator tests fail since java.io.tmpdir pointed at directory
containing parentheses
[ https://issues.apache.org/jira/browse/QPID-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262826#comment-16262826 ]
ASF subversion and git services commented on QPID-7892:
-------------------------------------------------------
Commit b1eecae10f741f1564d1b04982da6be3427481e4 in qpid-broker-j's branch refs/heads/6.1.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b1eecae ]
QPID-7892: [Java Broker] Use Pattern#quote instead of own regexp escaping
Cherry picked from master 11a74ca.
> [Java Broker] Qpid Logback plugin RollingPolicyDecorator tests fail since java.io.tmpdir pointed at directory containing parentheses
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-7892
> URL: https://issues.apache.org/jira/browse/QPID-7892
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J, Java Tests
> Reporter: Keith Wall
> Assignee: Alex Rudyy
> Priority: Minor
>
> Currently on master the following tests are failing on Apache CI. The fails started at the point {{$\{java.io.tmpdir\}}} was reassigned to the Jenkins job's workspace directory. The workspace directory contains a pair of parentheses. The following tests are affected:
> {noformat}
> org.apache.qpid.server.logging.logback.RollingPolicyDecoratorTest.testSequentialRollover
> org.apache.qpid.server.logging.logback.RollingPolicyDecoratorTest.testRolloverRescanLimit
> org.apache.qpid.server.logging.logback.RollingPolicyDecoratorTest.testRolloverWithFile
> {noformat}
> I can see the issue is occurring because the regex match within {{org.apache.qpid.server.logging.logback.RollingPolicyDecorator.ScanTask#scan}} is treating the parentheses as regex meta characters and this is causing the test to fail.
> I do not yet understand if this issue is a simple a test one, or whether core code is affected.
> {{Pattern.escape}} can be used to escape regex metacharacters. Perhaps it should be used??
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org