You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/08 21:07:00 UTC

[GitHub] [kafka] dajac commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

dajac commented on a change in pull request #11474:
URL: https://github.com/apache/kafka/pull/11474#discussion_r745092766



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig,
         }
       }
     }
+
+    requestedTopicSet.foreach { case topic =>
+      brokerTopicStats.topicStats(topic).totalProduceRequestRate.mark()
+    }

Review comment:
       The downside of using 'map' is that it will create an intermediate collection.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org