[GitHub] cloudstack pull request #1549: CLOUDSTACK-9348: NioConnection improvements

[rhtyd <gi...@git.apache.org>]

Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1549#discussion_r68709839
  
    --- Diff: utils/src/main/java/com/cloud/utils/nio/NioConnection.java ---
    @@ -125,7 +125,7 @@ public boolean isStartup() {
         public Boolean call() throws NioConnectionException {
             while (_isRunning) {
                 try {
    -                _selector.select();
    +                _selector.select(1000);
    --- End diff --
    
    @swill this change ^^ causes the selector loop to never block indefinitely but at most 1 second. This ensures that reconnections are fast. If anyone experiences the behaviour that tel-netting to port 8250 causes agent to reconnect then, either (1) they are not using latest master or (2) they did not wait for up to one second (i.e. hit an edge case), in which case we can lower this number to 100-500 millisecond at the expense of increasing cpu usage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---