You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/06/19 08:22:20 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1590: MINIFICPP-2139 Fix build on ARM7 architecture

lordgamez opened a new pull request, #1590:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1590

   https://issues.apache.org/jira/browse/MINIFICPP-2139
   
   -------------
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1590: MINIFICPP-2139 Fix build on ARM7 architecture

Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1590: MINIFICPP-2139 Fix build on ARM7 architecture
URL: https://github.com/apache/nifi-minifi-cpp/pull/1590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1590: MINIFICPP-2139 Fix build on ARM7 architecture

Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1590:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1590#discussion_r1258492905


##########
thirdparty/rocksdb/arm7.patch:
##########


Review Comment:
   I would add a comment somewhere about where this patch is from



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1590: MINIFICPP-2139 Fix build on ARM7 architecture

Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1590:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1590#discussion_r1259438996


##########
thirdparty/rocksdb/arm7.patch:
##########


Review Comment:
   Added comment in a8b5142ab14600d902dac16507b28d59a4f3e680



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org