[jira] [Commented] (NIFI-13755) Controller Services sometimes not restarted when NiFi is restarted

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891048#comment-17891048 ] 

ASF subversion and git services commented on NIFI-13755:
--------------------------------------------------------

Commit 1aabc615ce923a07281bcb833e247ad3b51bcf42 in nifi's branch refs/heads/main from jrsteinebrey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1aabc615ce ]

NIFI-13755 Improved Controller Service Enabling Process (#9273)

- Updated Standard Controller Service Provider to enable requested Controller Services that do not depend on a disabled Controller Service, instead of failing to enable the entire set of requested Controller Services
- Updated enabling process improves behavior when restarting NiFi and attempting to enable large numbers of Controller Services, some of which depend on disabled Services

Signed-off-by: David Handermann <ex...@apache.org>

> Controller Services sometimes not restarted when NiFi is restarted
> ------------------------------------------------------------------
>
>                 Key: NIFI-13755
>                 URL: https://issues.apache.org/jira/browse/NIFI-13755
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.27.0, 2.0.0-M4
>            Reporter: Jim Steinebrey
>            Assignee: Jim Steinebrey
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Before Nifi was stopped, there were around 1000 controller services (cs) enabled and 500 disabled. After NiFi restarted, none of the controller services were enabled. This is very inconvenient because now someone has to manually restart just the 1000 that should be enabled. The normal NiFi restart behavior is to enable the 1000 cs and leave the 500 disabled to restore them to their state before the restart.
> I found the cause in StandardControllerServiceProvider.enableControllerServices()
> If a single enabled cs depends on another cs which is disabled, then NONE of the 1000 cs are enabled.
> My change is to only SKIP the enabling of any cs which is dependent on any disabled cs ancestor (cs can be linked multiple levels deep) and proceed to enable any cs which is not dependent on a disabled cs ancestor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)