[jira] [Commented] (HBASE-14216) Consolidate MR and Spark BulkLoad shared functions and string consts

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695629#comment-14695629 ] 

Andrew Purtell commented on HBASE-14216:
----------------------------------------

The string constant "hfile.compression" could go into the HFile class. Someone might suggest an alternate location. I'm fine with wherever as long as we define the string in one common place.

We have duplicated code in HBaseContext and HFileOutputFormat2 for creating HFile writers and then closing the HFile with necessary metadata included. From your work Ted see HBaseContext#getNewWriter and HBaseContext#close. We should lift this to shared library code so the details don't start subtly drifting. 

> Consolidate MR and Spark BulkLoad shared functions and string consts
> --------------------------------------------------------------------
>
>                 Key: HBASE-14216
>                 URL: https://issues.apache.org/jira/browse/HBASE-14216
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Malaska
>            Assignee: Ted Malaska
>            Priority: Minor
>
> This is a follow up jira is HBASE-14150.  Andrew P had noticed code that could be consolidate between MR and Spark bulk load code.
> Before I get started I need advice to know where the consolidated code should live.  Once I have the location I can start coding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)