You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/06/19 12:19:38 UTC
[GitHub] [qpid-dispatch] pwright opened a new pull request #764: ENTMQIC-2175 logging and vhost note
pwright opened a new pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] fgiorgetti commented on pull request #764: DISPATCH-1719 logging and vhost note
Posted by GitBox <gi...@apache.org>.
fgiorgetti commented on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-664745562
@pwright looks good to me,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] pwright commented on pull request #764: DISPATCH-1719 logging and vhost note
Posted by GitBox <gi...@apache.org>.
pwright commented on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-661815357
@fgiorgetti could you approve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on pull request #764: ENTMQIC-2175 logging and vhost note
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-646660992
Please use DISPATCH Jira references.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #764: ENTMQIC-2175 logging and vhost note
Posted by GitBox <gi...@apache.org>.
bhardesty commented on a change in pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#discussion_r442810275
##########
File path: docs/books/modules/user-guide/viewing-log-entries.adoc
##########
@@ -50,6 +50,8 @@ Wed Jun 7 17:49:32 2019 SERVER (none) [2]:0 -> @flow(19) [next-incoming-id=1, i
----
--
+NOTE: `vhost` entries are only logged if `multiTenant` is set to `true` in the router configuration file.
+
Review comment:
FYI, I don't know if it's necessary in this case, but if you want to refer to the default path and name of the config file, you can use this attribute:
https://github.com/apache/qpid-dispatch/blob/df22f36b9d45ccf9c555f847919c911e6c6d57e8/docs/books/common/attributes.adoc#L46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #764: DISPATCH-1719 logging and vhost note
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] fgiorgetti edited a comment on pull request #764: DISPATCH-1719 logging and vhost note
Posted by GitBox <gi...@apache.org>.
fgiorgetti edited a comment on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-664745562
@pwright looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] pwright commented on pull request #764: ENTMQIC-2175 logging and vhost note
Posted by GitBox <gi...@apache.org>.
pwright commented on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-646605754
@ted-ross does this address the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] pwright commented on pull request #764: DISPATCH-1719 logging and vhost note
Posted by GitBox <gi...@apache.org>.
pwright commented on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-665008888
@fgiorgetti I'm not sure who should merge this, I don't have the privs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #764: DISPATCH-1719 logging and vhost note
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #764:
URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-665075721
@bhardesty has the powers. Or me. I'll merge this myself now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org