You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/03/28 11:17:00 UTC
[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1394: [CELEBORN-485] Make celeborn.push.replicate.enabled default to false
waitinfuture opened a new pull request, #1394:
URL: https://github.com/apache/incubator-celeborn/pull/1394
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Some of users and new comers don't want replication on, so better to make is default to false.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
Yes, the default value of celeborn.push.replicate.enabled changes from true to false.
### How was this patch tested?
UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1394: [CELEBORN-485] Make celeborn.push.replicate.enabled default to false
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1394:
URL: https://github.com/apache/incubator-celeborn/pull/1394#issuecomment-1493907761
> > For such changes, maybe we should introduce a migration guide part.
>
> Will add in the website
Added "migration guide" in website https://celeborn.apache.org/docs/latest/migration/ , merging this PR to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1394: [CELEBORN-485] Make celeborn.push.replicate.enabled default to false
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1394:
URL: https://github.com/apache/incubator-celeborn/pull/1394#issuecomment-1486912134
> For such changes, maybe we should introduce a migration guide part.
Will add in the website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1394: [CELEBORN-485] Make celeborn.push.replicate.enabled default to false
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1394:
URL: https://github.com/apache/incubator-celeborn/pull/1394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1394: [CELEBORN-485] Make celeborn.push.replicate.enabled default to false
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1394:
URL: https://github.com/apache/incubator-celeborn/pull/1394#issuecomment-1486752451
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1394](https://codecov.io/gh/apache/incubator-celeborn/pull/1394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c9a847c) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/cbe65a7e2e25b81601c996fa12ac897c3b4ae9fc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbe65a7) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #1394 +/- ##
============================================
+ Coverage 29.85% 29.90% +0.05%
- Complexity 913 917 +4
============================================
Files 223 223
Lines 18664 18664
Branches 1987 1987
============================================
+ Hits 5571 5580 +9
+ Misses 12699 12696 -3
+ Partials 394 388 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `81.64% <100.00%> (+0.05%)` | :arrow_up: |
... and [3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1394: [CELEBORN-485] Make celeborn.push.replicate.enabled default to false
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1394:
URL: https://github.com/apache/incubator-celeborn/pull/1394#issuecomment-1486726585
For such changes, maybe we should introduce a migration guide part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org