You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/09/08 13:24:46 UTC
[GitHub] [systemds] tobiasrieger opened a new pull request #1050: [WIP][SYSTEMDS-2550] implemented Externalizable for ListObjects
tobiasrieger opened a new pull request #1050:
URL: https://github.com/apache/systemds/pull/1050
To transmit the parameter ListObject of MatrixObjects to the federated Workers it was necessary to serialize a list. This pull request also contains a unit test, with a recursive call by testing a list in a list. Also old code in the test was changed to a parameterized variant for brevity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on a change in pull request #1050: [WIP][SYSTEMDS-2550] implemented Externalizable for ListObjects
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #1050:
URL: https://github.com/apache/systemds/pull/1050#discussion_r486332722
##########
File path: src/test/java/org/apache/sysds/test/component/paramserv/SerializationTest.java
##########
@@ -19,7 +19,9 @@
package org.apache.sysds.test.component.paramserv;
+import java.io.*;
Review comment:
no wildcard imports
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] tobiasrieger closed pull request #1050: [WIP][SYSTEMDS-2550] implemented Externalizable for ListObjects
Posted by GitBox <gi...@apache.org>.
tobiasrieger closed pull request #1050:
URL: https://github.com/apache/systemds/pull/1050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] tobiasrieger commented on a change in pull request #1050: [WIP][SYSTEMDS-2550] implemented Externalizable for ListObjects
Posted by GitBox <gi...@apache.org>.
tobiasrieger commented on a change in pull request #1050:
URL: https://github.com/apache/systemds/pull/1050#discussion_r486364637
##########
File path: src/test/java/org/apache/sysds/test/component/paramserv/SerializationTest.java
##########
@@ -19,7 +19,9 @@
package org.apache.sysds.test.component.paramserv;
+import java.io.*;
Review comment:
thank you, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org