You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/07 06:53:31 UTC

[GitHub] eolivelli commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

eolivelli commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/809#discussion_r254563475
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
 ##########
 @@ -203,13 +203,15 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
             }
         }
 
+        // Use a single listener instance to reduce GC
+        private final GenericFutureListener<Future<Void>> onWriteCompletedListener = (f) -> {
+            LOG.trace("write {}", f.isSuccess() ? "complete" : "failed");
 
 Review comment:
   if log.isTraceEnabled...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services