[jira] [Commented] (HBASE-25767) The masterServices field in LocalityBasedCandidateGenerator is useless

["Duo Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318783#comment-17318783 ] 

Duo Zhang commented on HBASE-25767:
-----------------------------------

Oh, after removing the masterServices field, TestStochasticLoadBalancerLargeCluster starts to fail, as it can not balance a large cluster at once.

But I do not think the old logic is correct, it just uses a fallback logic which is only used for testing, which means in real large cluster, StochasticLoadBalancer does not work well.

Let me think how to fix this.

[~stack] FYI.

> The masterServices field in LocalityBasedCandidateGenerator is useless
> ----------------------------------------------------------------------
>
>                 Key: HBASE-25767
>                 URL: https://issues.apache.org/jira/browse/HBASE-25767
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> Similar to HBASE-25759, it is just used to test whether we should skip calculation, but in production masterServices will never be null.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)