You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/27 19:35:12 UTC
Review Request 63373: Reduce white-space on role and env pages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63373/
-----------------------------------------------------------
Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
Repository: aurora
Description
-------
We had a request to show more content on the job list (the new UI increases the size of an item by about 20px per item).
Diffs
-----
ui/src/main/sass/components/_job-list-page.scss a716b9869b8a00d8232eacdd79c47f4b63055217
Diff: https://reviews.apache.org/r/63373/diff/1/
Testing
-------
See before and after below.
File Attachments
----------------
Reduced
https://reviews.apache.org/media/uploaded/files/2017/10/27/e09fae56-a110-4e68-a7c4-6317f366dc58__Screen_Shot_2017-10-27_at_12.31.38_PM.png
Before
https://reviews.apache.org/media/uploaded/files/2017/10/27/6242deee-9916-4df2-8c34-7fed89ec1b94__Screen_Shot_2017-10-27_at_12.31.46_PM.png
Thanks,
David McLaughlin
Re: Review Request 63373: Reduce white-space on role and env pages
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63373/#review189470
-----------------------------------------------------------
Master (5a26c8b) is red with this patch.
./build-support/jenkins/build.sh
thrift-0.9.1/tutorial/py/PythonClient.py
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
Makefile:49: recipe for target 'thrift-0.9.1/compiler/cpp/thrift' failed
make: Leaving directory '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
:api:generateThriftJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' finished with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 15s
7 actionable tasks: 1 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 27, 2017, 7:35 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63373/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 7:35 p.m.)
>
>
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We had a request to show more content on the job list (the new UI increases the size of an item by about 20px per item).
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-list-page.scss a716b9869b8a00d8232eacdd79c47f4b63055217
>
>
> Diff: https://reviews.apache.org/r/63373/diff/1/
>
>
> Testing
> -------
>
> See before and after below.
>
>
> File Attachments
> ----------------
>
> Reduced
> https://reviews.apache.org/media/uploaded/files/2017/10/27/e09fae56-a110-4e68-a7c4-6317f366dc58__Screen_Shot_2017-10-27_at_12.31.38_PM.png
> Before
> https://reviews.apache.org/media/uploaded/files/2017/10/27/6242deee-9916-4df2-8c34-7fed89ec1b94__Screen_Shot_2017-10-27_at_12.31.46_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63373: Reduce white-space on role and env pages
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63373/#review189471
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On Oct. 27, 2017, 7:35 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63373/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 7:35 p.m.)
>
>
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We had a request to show more content on the job list (the new UI increases the size of an item by about 20px per item).
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-list-page.scss a716b9869b8a00d8232eacdd79c47f4b63055217
>
>
> Diff: https://reviews.apache.org/r/63373/diff/1/
>
>
> Testing
> -------
>
> See before and after below.
>
>
> File Attachments
> ----------------
>
> Reduced
> https://reviews.apache.org/media/uploaded/files/2017/10/27/e09fae56-a110-4e68-a7c4-6317f366dc58__Screen_Shot_2017-10-27_at_12.31.38_PM.png
> Before
> https://reviews.apache.org/media/uploaded/files/2017/10/27/6242deee-9916-4df2-8c34-7fed89ec1b94__Screen_Shot_2017-10-27_at_12.31.46_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>