You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/17 18:21:16 UTC

[GitHub] [spark] grundprinzip commented on a diff in pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL

grundprinzip commented on code in PR #38283:
URL: https://github.com/apache/spark/pull/38283#discussion_r997376731


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -41,6 +41,7 @@ message Relation {
     Aggregate aggregate = 9;
     SQL sql = 10;
     LocalRelation local_relation = 11;
+    Intersect intersect = 12;

Review Comment:
   Wait, don't we have a Union type that does this (e.g. from the set operations?)
   @amaliujia ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org