You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:15:04 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1071: MINIFICPP-1548 - Use the same rocksdb instance for multiple repositories

adamdebreceni commented on pull request #1071:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1071#issuecomment-859562086


   > the changes look good 👍 , but why did you revert to using separate dbs by default in [d787a92](https://github.com/apache/nifi-minifi-cpp/commit/d787a926dafcbd70074bbd3c9b94ab1a1a3ca3c8) ?
   > I also feel like if this shared db isnt the only option then we should document this `minifidb://` scheme and how to set these (nifi.flowfile.repository.directory.default, nifi.database.content.repository.directory.default, nifi.state.manangement.provider.local.path) values to use separate/same dbs (minifi.properties or README ?)
   
   added documentation to `CONFIGURE.md`, adding the possibility and making it default are (IMO) two different decisions (the latter might not even be justified now), I feel like if we decide to change the default behavior we should do it in a separate PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org