You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/04/03 10:58:08 UTC

[GitHub] [kylin] codecov-io commented on issue #579: KYLIN-3926 set sourceRecordCount when updating statistics

codecov-io commented on issue #579: KYLIN-3926 set sourceRecordCount when updating statistics
URL: https://github.com/apache/kylin/pull/579#issuecomment-479440908
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=h1) Report
   > Merging [#579](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7a1f90d598b0254b94f36fa0e381c66274aced83?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/579/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #579      +/-   ##
   ============================================
   - Coverage     25.37%   25.37%   -0.01%     
     Complexity     5803     5803              
   ============================================
     Files          1372     1372              
     Lines         81137    81151      +14     
     Branches      11377    11380       +3     
   ============================================
   + Hits          20591    20594       +3     
   - Misses        58531    58544      +13     
   + Partials       2015     2013       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...in/engine/mr/steps/MergeStatisticsWithOldStep.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VTdGF0aXN0aWNzV2l0aE9sZFN0ZXAuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/engine/mr/common/CubeStatsWriter.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0N1YmVTdGF0c1dyaXRlci5qYXZh) | `58.62% <0%> (-4.35%)` | `3 <0> (ø)` | |
   | [...che/kylin/engine/mr/steps/MergeStatisticsStep.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VTdGF0aXN0aWNzU3RlcC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/engine/mr/common/CubeStatsReader.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0N1YmVTdGF0c1JlYWRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/579/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=footer). Last update [7a1f90d...2b9108b](https://codecov.io/gh/apache/kylin/pull/579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services