You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/29 16:31:41 UTC

[GitHub] [cloudstack] nvazquez opened a new pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

nvazquez opened a new pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437


   ## Description
   Fix for VMware SSVM recreation using deploy-as-is system VM templates
   
   Fixes:
   - Register a new system VM template
   - Recreate SSVM -> ERROR
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   VMware environment
   
   - Register a new system VM template
   - Recreate SSVM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-723059353


   Let's merge once this passes, pl check if the last test env failed due to a regression @nvazquez thnx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-721894745


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r517822442



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
         int volumesNumber = 1;
         List<DatadiskTO> templateAsIsDisks = null;
         String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {

Review comment:
       Thanks for fixing that case @nvazquez 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718961870


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-721805953


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718937929


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-721894360


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r515808469



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
         int volumesNumber = 1;
         List<DatadiskTO> templateAsIsDisks = null;
         String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {

Review comment:
       Good point; @nvazquez can you check for CPVM and other systemvm types as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-721869469


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2332


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718937627


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r517435355



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
         int volumesNumber = 1;
         List<DatadiskTO> templateAsIsDisks = null;
         String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {

Review comment:
       I've pushed a fix to check for running SSVMs in the zone as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r514835332



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
         int volumesNumber = 1;
         List<DatadiskTO> templateAsIsDisks = null;
         String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {

Review comment:
       do we have to also keep a check for other system VMs ? or pass this condition only for user VMs ? I see a problem when CPVM is tried to recreate when SSVM is not there, we might get into same issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718873508


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-723026610


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-723026272


   @blueorangutan test centos7 vmware-67u3
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-721851233


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718962437


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718937393


   @nvazquez unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-719426408


   <b>Trillian test result (tid-3109)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47441 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4437-t3109-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 785.40 | test_kubernetes_clusters.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.20 | test_snapshots.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 19.50 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 355.58 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718936925


   @blueorangutan test centos7 vmware67-u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718874103


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-723063448


   @rhtyd tests running now, previous env failed to start the marvin VM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-718900969


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2310


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-723327965


   <b>Trillian test result (tid-3132)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38263 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4437-t3132-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 774.64 | test_kubernetes_clusters.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#issuecomment-721852011


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org