You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "XieJiann (via GitHub)" <gi...@apache.org> on 2023/01/29 07:54:03 UTC
[GitHub] [doris] XieJiann opened a new pull request, #16197: [fix](Nereids): Fix some functions error
XieJiann opened a new pull request, #16197:
URL: https://github.com/apache/doris/pull/16197
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by github-actions.
github-actions[bot] commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407684855
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by github-actions.
github-actions[bot] commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407617480
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by github-actions.
github-actions[bot] commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407591645
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #16197: [fix](Nereids): Fix some functions error
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #16197:
URL: https://github.com/apache/doris/pull/16197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by github-actions.
github-actions[bot] commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407600126
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #16197: [fix](Nereids): Fix some functions error
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #16197:
URL: https://github.com/apache/doris/pull/16197#discussion_r1089979474
##########
regression-test/suites/nereids_function_p0/scalar_function/R-W.groovy:
##########
@@ -122,62 +119,56 @@ suite("nereids_scalar_fn_4") {
qt_sql "select sm3sum(kstr) from fn_test order by kstr"
sql "select sm4_decrypt(kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1"
sql "select sm4_decrypt(kstr, kstr) from fn_test order by kstr, kstr"
- // core
- // sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1"
+
+ sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1"
sql "select sm4_decrypt(kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr"
- // cannot find function
- // qt_sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"
- // qt_sql "select sm4_decrypt(kstr, kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr, kstr"
+ qt_sql """ select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1, "SM4_128_ECB") from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1 """
+ qt_sql """ select sm4_decrypt(kstr, kstr, kstr, "SM4_128_ECB") from fn_test order by kstr, kstr, kstr, kstr """
sql "select sm4_encrypt(kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1"
sql "select sm4_encrypt(kstr, kstr) from fn_test order by kstr, kstr"
sql "select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1"
sql "select sm4_encrypt(kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr"
- // cannot find function
- // qt_sql "select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"
- // qt_sql "select sm4_encrypt(kstr, kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr, kstr"
+ qt_sql """ select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1, "SM4_128_ECB") from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"""
+ qt_sql """ select sm4_encrypt(kstr, kstr, kstr, "SM4_128_ECB") from fn_test order by kstr, kstr, kstr, kstr"""
Review Comment:
what will happen, if the last arg is illegal, such as '1234'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by github-actions.
github-actions[bot] commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407594462
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #16197: [fix](Nereids): Fix some functions error
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #16197:
URL: https://github.com/apache/doris/pull/16197#discussion_r1089979474
##########
regression-test/suites/nereids_function_p0/scalar_function/R-W.groovy:
##########
@@ -122,62 +119,56 @@ suite("nereids_scalar_fn_4") {
qt_sql "select sm3sum(kstr) from fn_test order by kstr"
sql "select sm4_decrypt(kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1"
sql "select sm4_decrypt(kstr, kstr) from fn_test order by kstr, kstr"
- // core
- // sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1"
+
+ sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1"
sql "select sm4_decrypt(kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr"
- // cannot find function
- // qt_sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"
- // qt_sql "select sm4_decrypt(kstr, kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr, kstr"
+ qt_sql """ select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1, "SM4_128_ECB") from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1 """
+ qt_sql """ select sm4_decrypt(kstr, kstr, kstr, "SM4_128_ECB") from fn_test order by kstr, kstr, kstr, kstr """
sql "select sm4_encrypt(kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1"
sql "select sm4_encrypt(kstr, kstr) from fn_test order by kstr, kstr"
sql "select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1"
sql "select sm4_encrypt(kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr"
- // cannot find function
- // qt_sql "select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1, kvchrs1) from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"
- // qt_sql "select sm4_encrypt(kstr, kstr, kstr, kstr) from fn_test order by kstr, kstr, kstr, kstr"
+ qt_sql """ select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1, "SM4_128_ECB") from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"""
+ qt_sql """ select sm4_encrypt(kstr, kstr, kstr, "SM4_128_ECB") from fn_test order by kstr, kstr, kstr, kstr"""
Review Comment:
what will happen, if the last arg is illegal, such as '1234'. the legacy planner return `NULL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407639238
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.18 seconds
load time: 498 seconds
storage size: 17122475404 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129113929_clickbench_pr_86410.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error
Posted by github-actions.
github-actions[bot] commented on PR #16197:
URL: https://github.com/apache/doris/pull/16197#issuecomment-1407684862
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org