You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uplsh580 (via GitHub)" <gi...@apache.org> on 2026/01/28 16:59:38 UTC
[PR] Fix import errors not showing in web UI for local bundles, git bundles when DAG creation fails [airflow]
uplsh580 opened a new pull request, #61171:
URL: https://github.com/apache/airflow/pull/61171
## Related Issue
Issue: https://github.com/apache/airflow/issues/59272#issuecomment-3809576362
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix import errors not showing in web UI for bundles(local, git) when DAG creation fails [airflow]
Posted by "uplsh580 (via GitHub)" <gi...@apache.org>.
uplsh580 commented on PR #61171:
URL: https://github.com/apache/airflow/pull/61171#issuecomment-3812890789
## Performance Consideration
The current implementation filters import errors in-memory after fetching paginated results. This ensures we include import errors from files that didn't create any DAGs.
**Trade-offs:**
**Current approach (in-memory filtering):**
- ✅ Simpler query logic
- ✅ Works correctly for the use case
- ⚠️ May fetch more data than needed if most import errors are filtered out
- ⚠️ Pagination may return fewer items than requested (but still accurate for UI)
**Alternative approach (DB-level filtering with LEFT JOIN + EXISTS):**
- ✅ Only fetches authorized items
- ✅ More accurate pagination
- ⚠️ More complex query
- ⚠️ Requires indexes on `(bundle_name, relative_fileloc)` and `(bundle_name, dag_id)` for optimal performance
**Questions for reviewers:**
- Does the in-memory filtering approach align with similar patterns in the codebase?
- Are there any concerns with the current implementation approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix import errors not showing in web UI for bundles(local, git) when DAG creation fails [airflow]
Posted by "uplsh580 (via GitHub)" <gi...@apache.org>.
uplsh580 commented on PR #61171:
URL: https://github.com/apache/airflow/pull/61171#issuecomment-3812856395
## Validation
### Local Dag Bundle
<img width="1521" height="826" alt="image" src="https://github.com/user-attachments/assets/3809bb3a-6c97-4c83-9298-9fef7eb7be8b" />
<img width="1454" height="839" alt="image" src="https://github.com/user-attachments/assets/09073018-6169-4ca6-b0a8-8da0348114dc" />
<img width="1170" height="676" alt="image" src="https://github.com/user-attachments/assets/a6ae72d6-e493-4a64-afb1-8b0a53990dd6" />
### Git Dag Bundle
<img width="1690" height="829" alt="스크린샷 2026-01-29 오전 1 55 23" src="https://github.com/user-attachments/assets/e4923e75-e0fa-4bcd-9636-31cdcbe91bf6" />
<img width="1543" height="811" alt="스크린샷 2026-01-29 오전 1 55 31" src="https://github.com/user-attachments/assets/1941de53-8652-4bf9-8547-510897667825" />
<img width="1230" height="608" alt="스크린샷 2026-01-29 오전 1 55 46" src="https://github.com/user-attachments/assets/6efea227-56be-4f28-bc28-7402846bed57" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix import errors not showing in web UI for bundles(local, git) when DAG creation fails [airflow]
Posted by "uplsh580 (via GitHub)" <gi...@apache.org>.
uplsh580 closed pull request #61171: Fix import errors not showing in web UI for bundles(local, git) when DAG creation fails
URL: https://github.com/apache/airflow/pull/61171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix import errors not showing in web UI for bundles(local, git) when DAG creation fails [airflow]
Posted by "uplsh580 (via GitHub)" <gi...@apache.org>.
uplsh580 commented on PR #61171:
URL: https://github.com/apache/airflow/pull/61171#issuecomment-3818646185
This was fixed in PR #61163.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org