You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Antoine Mischler (JIRA)" <ji...@apache.org> on 2010/05/26 14:33:33 UTC
[jira] Created: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Tapestry should ignore FXBase methods in JavaFX module classes
--------------------------------------------------------------
Key: TAP5-1171
URL: https://issues.apache.org/jira/browse/TAP5-1171
Project: Tapestry 5
Issue Type: Bug
Reporter: Antoine Mischler
Assignee: Howard M. Lewis Ship
Fix For: 5.2.0
Groovy (and probably other alternative languages as well) enriches its classes with public synthetic methods. For module classes written in Groovy, Tapestry complains that it doesn't recognize these methods. Because synthetic methods are obviously not meant for Tapestry, they should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Affects Version/s: 5.2.0
Issue Type: New Feature (was: Bug)
Description: JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored. (was: Groovy (and probably other alternative languages as well) enriches its classes with public synthetic methods. For module classes written in Groovy, Tapestry complains that it doesn't recognize these methods. Because synthetic methods are obviously not meant for Tapestry, they should be ignored.)
Fix Version/s: (was: 5.2.0)
Component/s: tapestry-ioc
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Attachment: fix_for_TAP5-1171.patch
Added a patch proposition
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: fix_for_TAP5-1171.patch, InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Nicolas Delsaux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871731#action_12871731 ]
Nicolas Delsaux commented on TAP5-1171:
---------------------------------------
As all JavaFX objects extend the FXBase root class, it could be possible to mimic behaviour of TAP5 830.
It can be done witouth prior knowledge of JavaFX presence, by simply checking if object class implements FXObject (indeed, Antoine, as JavaFX objects may sometimes be subclasses of Java objects, the inheritance from FXBase is not always true, which IS the case of the implementation of FXObject). So a code like this one
try {
if(Class.forName("com.sun.javafx.runtime.FXObject").isAssignableFrom(myObject.getClass())) {
// Speciic JavaFX code goes here
}
} catch(ClassNotFoundException cnfe) {
// this code surely isn't JavaFX code
}
could be added where TAP5-830 handles synthetic method removall from Groovy.
However, I wonder how will Tapestry-IOC grow if all languages supported by the Java platform need their specific hacks to handle correctly local methods.
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Attachment: log.txt
Execution log of the attached JavaFX script showing the full list of unrecognized public methods
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Attachment: fix_for_TAP5-1171.patch
Added a patch proposition
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: fix_for_TAP5-1171.patch, InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Attachment: InjectionTest-src.zip
Sources of the JavaFX project using tapestry-ioc.
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871727#action_12871727 ]
Antoine Mischler commented on TAP5-1171:
----------------------------------------
Sorry for the assignement of this issue, it looks like creating it by cloning was not the best way to do it...
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Nicolas Delsaux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871731#action_12871731 ]
Nicolas Delsaux commented on TAP5-1171:
---------------------------------------
As all JavaFX objects extend the FXBase root class, it could be possible to mimic behaviour of TAP5 830.
It can be done witouth prior knowledge of JavaFX presence, by simply checking if object class implements FXObject (indeed, Antoine, as JavaFX objects may sometimes be subclasses of Java objects, the inheritance from FXBase is not always true, which IS the case of the implementation of FXObject). So a code like this one
try {
if(Class.forName("com.sun.javafx.runtime.FXObject").isAssignableFrom(myObject.getClass())) {
// Speciic JavaFX code goes here
}
} catch(ClassNotFoundException cnfe) {
// this code surely isn't JavaFX code
}
could be added where TAP5-830 handles synthetic method removall from Groovy.
However, I wonder how will Tapestry-IOC grow if all languages supported by the Java platform need their specific hacks to handle correctly local methods.
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Affects Version/s: 5.2.0
Issue Type: New Feature (was: Bug)
Description: JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored. (was: Groovy (and probably other alternative languages as well) enriches its classes with public synthetic methods. For module classes written in Groovy, Tapestry complains that it doesn't recognize these methods. Because synthetic methods are obviously not meant for Tapestry, they should be ignored.)
Fix Version/s: (was: 5.2.0)
Component/s: tapestry-ioc
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871727#action_12871727 ]
Antoine Mischler commented on TAP5-1171:
----------------------------------------
Sorry for the assignement of this issue, it looks like creating it by cloning was not the best way to do it...
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914700#action_12914700 ]
Howard M. Lewis Ship commented on TAP5-1171:
--------------------------------------------
Sounds like Sun^H^H^HOracle is killing JavaFX the scripting language, and just keeping the APIs.
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: fix_for_TAP5-1171.patch, InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Attachment: InjectionTest-src.zip
Sources of the JavaFX project using tapestry-ioc.
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914700#action_12914700 ]
Howard M. Lewis Ship commented on TAP5-1171:
--------------------------------------------
Sounds like Sun^H^H^HOracle is killing JavaFX the scripting language, and just keeping the APIs.
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: fix_for_TAP5-1171.patch, InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1171) Tapestry should ignore FXBase methods
in JavaFX module classes
Posted by "Antoine Mischler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Mischler updated TAP5-1171:
-----------------------------------
Attachment: log.txt
Execution log of the attached JavaFX script showing the full list of unrecognized public methods
> Tapestry should ignore FXBase methods in JavaFX module classes
> --------------------------------------------------------------
>
> Key: TAP5-1171
> URL: https://issues.apache.org/jira/browse/TAP5-1171
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-ioc
> Affects Versions: 5.2.0
> Reporter: Antoine Mischler
> Assignee: Howard M. Lewis Ship
> Attachments: InjectionTest-src.zip, log.txt
>
>
> JavaFX classes always extends the com.sun.javafx.runtime.FXBase class. For module classes written in JavaFX, Tapestry complains that it doesn't recognize the public methods from FXBase. These methods should be ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.