You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/20 08:24:48 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request #1114: [CI][License]Exclude license check of example
CalvinKirs opened a new pull request #1114:
URL: https://github.com/apache/incubator-seatunnel/pull/1114
because it won't be in our binary tar
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1114: [CI][License]Exclude license check of example
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1114:
URL: https://github.com/apache/incubator-seatunnel/pull/1114#discussion_r788623360
##########
File path: tools/dependencies/checkLicense.sh
##########
@@ -17,7 +17,7 @@
# limitations under the License.
#
-./mvnw dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
+./mvnw -pl '!seatunnel-examples,!seatunnel-examples/seatunnel-spark-examples,!seatunnel-examples/seatunnel-flink-examples' dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
Review comment:
Good idea.thx:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1114: [CI][License]Exclude license check of example
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1114:
URL: https://github.com/apache/incubator-seatunnel/pull/1114#discussion_r788569581
##########
File path: tools/dependencies/checkLicense.sh
##########
@@ -17,7 +17,7 @@
# limitations under the License.
#
-./mvnw dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
+./mvnw -pl '!seatunnel-examples,!seatunnel-examples/seatunnel-spark-examples,!seatunnel-examples/seatunnel-flink-examples' dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
Review comment:
can you try to add a plugin declaration in `seatunnel-examples` with `skip=true`, so when people add new examples they don't need to modify this file.
in file `seatunnel/seatunnel-examples/pom.xml`, the plugin should be extended by all children modules
```xml
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1114: [CI][License]Exclude license check of example
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1114:
URL: https://github.com/apache/incubator-seatunnel/pull/1114#discussion_r788571923
##########
File path: tools/dependencies/checkLicense.sh
##########
@@ -17,7 +17,7 @@
# limitations under the License.
#
-./mvnw dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
+./mvnw -pl '!seatunnel-examples,!seatunnel-examples/seatunnel-spark-examples,!seatunnel-examples/seatunnel-flink-examples' dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
Review comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1114: [CI][License]Exclude license check of example
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1114:
URL: https://github.com/apache/incubator-seatunnel/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org