Re: [PR] ParseResult: non-mutating lookup, explicit getOrCreate() and no empty documents emitted [stormcrawler]

["dpol1 (via GitHub)" <gi...@apache.org>]

dpol1 commented on PR #2112:
URL: https://github.com/apache/stormcrawler/pull/2112#issuecomment-5490333363

   Compat side looks well handled - deprecated `get()` keeps auto-create, all in-tree callers moved to `getOrCreate`. Two questions on the emit side.
   
   The empty-entry skip is silent - no log, counter or opt-out. URL-only subdocuments as a signal is a real pattern (this PR patched its own fixture for exactly that); should we at least count the skips and add a release-note line for filter authors?
   
   Also wondering: could the skip apply only to entries other than the tuple's own URL? Phantoms are by construction subdocuments, and exempting the parent would rule out the corner case where the main document vanishes and the URL keeps refetching.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org