[GitHub] [groovy] danielsun1106 edited a comment on issue #905: GROOVY-8339: Fix warning "An illegal reflective access operation has …

[GitBox <gi...@apache.org>]

danielsun1106 edited a comment on issue #905: GROOVY-8339: Fix warning "An illegal reflective access operation has …
URL: https://github.com/apache/groovy/pull/905#issuecomment-483506325
 
 
   > Given that VMPlugin is designed to run the correct method for the version of the JVM we are using, we shouldn't need to also check the version
   
   Agreed.
   
   > We have some functionality in ReflectionUtils and some similar functionality in VMPlugin and it's not clear to me that they aren't all at the same level - if that is the case we'd need to document it that way but I suspect we can consolidate into one level
   
   What I know about vm plugins is just to provide the plug-in functions for different JVMs. But vm plugins have little abstraction, just some concrete implementations. It's better to rely on abstraction if we want some stable API. (My 2 cents)
   How about moving the implementation of the following method to VMPlugin(e.g. Java5-Java9 plugins), then add a method in `ReflectionUtils` with same signatures delegating to the method in VMPlugin.
   https://github.com/apache/groovy/blob/2a8effa0880d245f1a01417974c812aac9410bd4/src/main/java/org/codehaus/groovy/reflection/ReflectionUtils.java#L143
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services